x/tools/goimports BUG: extra blank line after formatting

[ban11111]

What version of Go Tool are you using (go tool version)?

 golang.org/x/tools  v0.1.11

Does this issue reproduce with the latest release?

yes

What did you do?

for example, when there are:

import (
    "golang.org/x/tools/imports"
    "testing"
    "fmt"

    "github.com/xx/yy"
    "github.com/aa/bb"
)

simply run goimports formating the file

What did you expect to see?

after formatting:

import (
    "fmt
    "testing"

    "github.com/xx/yy"
    "github.com/aa/bb"
    "golang.org/x/tools/imports"
)

What did you see instead?

after formatting:

import (
    "fmt
    "testing"

    "golang.org/x/tools/imports"

    "github.com/xx/yy"
    "github.com/aa/bb"
)

[rsc]

I don't believe this is a bug. There is no rule that imports should only have at most two blocks. Goimports moves non-std imports out of the std section, but it does not (nor should it) presume that they belong in some other existing section. Instead it creates a new one.

[seankhliao]

Duplicate of #20818