Skip to content

Commit 406355a

Browse files
dmitshurgopherbot
authored andcommitted
all: update go directive to 1.18
Done with: go get [email protected] go mod tidy go fix ./... Using go1.21.3. While here, use testing.T.Helper directly and delete go19_test.go. For golang/go#60268. Change-Id: I924bb6d107180a04d1f879003b169c7f792d8dd4 Reviewed-on: https://go-review.googlesource.com/c/review/+/534198 Reviewed-by: Dmitri Shuralyov <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]>
1 parent f951e77 commit 406355a

File tree

3 files changed

+3
-20
lines changed

3 files changed

+3
-20
lines changed

git-codereview/go19_test.go

Lines changed: 0 additions & 14 deletions
This file was deleted.

git-codereview/pending_test.go

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,6 @@ import (
1414
"testing"
1515
)
1616

17-
// setHelper calls t.Helper() for Go 1.9+ (see go19_test.go) and does nothing otherwise.
18-
var setHelper = func(t *testing.T) {}
19-
2017
func TestPendingNone(t *testing.T) {
2118
gt := newGitTest(t)
2219
defer gt.done()
@@ -470,12 +467,12 @@ func testPendingReply(srv *gerritServer, id, rev, status string, unresolved int)
470467
}
471468

472469
func testPending(t *testing.T, want string) {
473-
setHelper(t)
470+
t.Helper()
474471
testPendingArgs(t, nil, want)
475472
}
476473

477474
func testPendingArgs(t *testing.T, args []string, want string) {
478-
setHelper(t)
475+
t.Helper()
479476
// fake auth information to avoid Gerrit error
480477
if !auth.initialized {
481478
auth.initialized = true

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
module golang.org/x/review
22

3-
go 1.13
3+
go 1.18

0 commit comments

Comments
 (0)