Skip to content

Commit 728ec52

Browse files
Michael Hirshleifercopybara-github
authored andcommitted
Remove Googletest FAQ entry for obsolete ProtocolMessageEquals and ProtocolMessageEquiv
* These long-dead variants of the proto matchers don't exist in the current version of Googletest. * No evidence of external usage: [the only external references I see](https://www.google.com/search?q=%22protocolmessageequals%22+OR+%22protocolmessageequals%22) are copies of this guide. Possibly they were already removed by the time Googletest was publicly released. PiperOrigin-RevId: 565358401 Change-Id: I61379b7333fa8ee19cd5520caedf2c539f54c2d7
1 parent af5ddbd commit 728ec52

File tree

1 file changed

+0
-21
lines changed

1 file changed

+0
-21
lines changed

docs/faq.md

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -128,27 +128,6 @@ both approaches a try. Practice is a much better way to grasp the subtle
128128
differences between the two tools. Once you have some concrete experience, you
129129
can much more easily decide which one to use the next time.
130130
131-
## I got some run-time errors about invalid proto descriptors when using `ProtocolMessageEquals`. Help!
132-
133-
{: .callout .note}
134-
**Note:** `ProtocolMessageEquals` and `ProtocolMessageEquiv` are *deprecated*
135-
now. Please use `EqualsProto`, etc instead.
136-
137-
`ProtocolMessageEquals` and `ProtocolMessageEquiv` were redefined recently and
138-
are now less tolerant of invalid protocol buffer definitions. In particular, if
139-
you have a `foo.proto` that doesn't fully qualify the type of a protocol message
140-
it references (e.g. `message<Bar>` where it should be `message<blah.Bar>`), you
141-
will now get run-time errors like:
142-
143-
```
144-
... descriptor.cc:...] Invalid proto descriptor for file "path/to/foo.proto":
145-
... descriptor.cc:...] blah.MyMessage.my_field: ".Bar" is not defined.
146-
```
147-
148-
If you see this, your `.proto` file is broken and needs to be fixed by making
149-
the types fully qualified. The new definition of `ProtocolMessageEquals` and
150-
`ProtocolMessageEquiv` just happen to reveal your bug.
151-
152131
## My death test modifies some state, but the change seems lost after the death test finishes. Why?
153132
154133
Death tests (`EXPECT_DEATH`, etc) are executed in a sub-process s.t. the

0 commit comments

Comments
 (0)