Skip to content

fix: elide string processing of 'fine' level log messages unless they will actually be logged #2055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 21, 2025
Merged

fix: elide string processing of 'fine' level log messages unless they will actually be logged #2055

merged 3 commits into from
Mar 21, 2025

Conversation

dconeybe
Copy link
Contributor

Fixes #2048

@dconeybe dconeybe added the api: firestore Issues related to the googleapis/java-firestore API. label Mar 21, 2025
@dconeybe dconeybe self-assigned this Mar 21, 2025
@dconeybe dconeybe requested a review from a team as a code owner March 21, 2025 02:48
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Mar 21, 2025
@cloud-java-bot cloud-java-bot requested a review from a team as a code owner March 21, 2025 03:19
tom-andersen
tom-andersen approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@tom-andersen tom-andersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subtle but nice!

@dconeybe dconeybe merged commit 22a41a2 into main Mar 21, 2025
23 checks passed
@dconeybe dconeybe deleted the Bug2048FineLogging branch March 21, 2025 14:32
@dconeybe dconeybe mentioned this pull request Mar 21, 2025
Closed
@release-please release-please bot mentioned this pull request Mar 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-andersen tom-andersen tom-andersen approved these changes

Assignees

@dconeybe dconeybe

Labels
api: firestore Issues related to the googleapis/java-firestore API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FINE logging of toString taking up a significant amount of CPU
3 participants
@dconeybe @tom-andersen @cloud-java-bot