Skip to content

Commit 17c142b

Browse files
authored
docs(sample): Update the subscribe with error listener and subscribe with exactly-once samples (#2437)
* docs(sample): Update SubscribeWithErrorListener sample to not rebuild the subscriber * docs(sample): Add locational endpoint for exactly-once subscriber sample * docs(sample): Add comment explaining reasoning for locational endpoint
1 parent 21cc376 commit 17c142b

File tree

2 files changed

+10
-7
lines changed

2 files changed

+10
-7
lines changed

samples/snippets/src/main/java/pubsub/SubscribeWithErrorListenerExample.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -62,15 +62,11 @@ public static void subscribeWithErrorListenerExample(String projectId, String su
6262
.setExecutorProvider(executorProvider)
6363
.build();
6464

65-
// Listen for unrecoverable failures. Rebuild a subscriber and restart subscribing
66-
// when the current subscriber encounters permanent errors.
65+
// Listen for unrecoverable failures.
6766
subscriber.addListener(
6867
new Subscriber.Listener() {
6968
public void failed(Subscriber.State from, Throwable failure) {
70-
System.out.println(failure.getStackTrace());
71-
if (!executorProvider.getExecutor().isShutdown()) {
72-
subscribeWithErrorListenerExample(projectId, subscriptionId);
73-
}
69+
System.out.println("Unrecoverable subscriber failure:" + failure.getStackTrace());
7470
}
7571
},
7672
MoreExecutors.directExecutor());

samples/snippets/src/main/java/pubsub/SubscribeWithExactlyOnceConsumerWithResponseExample.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,14 @@ public static void subscribeWithExactlyOnceConsumerWithResponseExample(
9595

9696
Subscriber subscriber = null;
9797
try {
98-
subscriber = Subscriber.newBuilder(subscriptionName, receiverWithResponse).build();
98+
// Pub/Sub's exactly once delivery guarantee only applies when subscribers connect to the
99+
// service in the same region.
100+
// For list of locational endpoints for Pub/Sub, see
101+
// https://cloud.google.com/pubsub/docs/reference/service_apis_overview#list_of_locational_endpoints
102+
subscriber =
103+
Subscriber.newBuilder(subscriptionName, receiverWithResponse)
104+
.setEndpoint("us-west1-pubsub.googleapis.com:443")
105+
.build();
99106
// Start the subscriber.
100107
subscriber.startAsync().awaitRunning();
101108
System.out.printf("Listening for messages on %s:\n", subscriptionName.toString());

0 commit comments

Comments
 (0)