From b0cf525ac98a2103d251b16cd7b75aed0a4a817e Mon Sep 17 00:00:00 2001 From: Sagar Agarwal Date: Tue, 1 Apr 2025 12:44:21 +0530 Subject: [PATCH 1/2] fix: Provide default implementations for Interval methods in AbstractStructReader --- .../com/google/cloud/spanner/AbstractStructReader.java | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractStructReader.java b/google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractStructReader.java index 10287544e96..e5b9fa00123 100644 --- a/google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractStructReader.java +++ b/google-cloud-spanner/src/main/java/com/google/cloud/spanner/AbstractStructReader.java @@ -67,7 +67,9 @@ protected String getPgJsonbInternal(int columnIndex) { protected abstract Date getDateInternal(int columnIndex); - protected abstract Interval getIntervalInternal(int columnIndex); + protected Interval getIntervalInternal(int columnIndex) { + throw new UnsupportedOperationException("Not implemented"); + } protected T getProtoMessageInternal(int columnIndex, T message) { throw new UnsupportedOperationException("Not implemented"); @@ -130,7 +132,9 @@ protected List getPgJsonbListInternal(int columnIndex) { protected abstract List getDateListInternal(int columnIndex); - protected abstract List getIntervalListInternal(int columnIndex); + protected List getIntervalListInternal(int columnIndex) { + throw new UnsupportedOperationException("Not implemented"); + } protected abstract List getStructListInternal(int columnIndex); From 588ab30f60df08af1edbc553488cfa19cfdd8842 Mon Sep 17 00:00:00 2001 From: Sagar Agarwal Date: Wed, 2 Apr 2025 17:07:32 +0530 Subject: [PATCH 2/2] addressed PR comments --- google-cloud-spanner/clirr-ignored-differences.xml | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/google-cloud-spanner/clirr-ignored-differences.xml b/google-cloud-spanner/clirr-ignored-differences.xml index 735b28dae2a..14ccf81c057 100644 --- a/google-cloud-spanner/clirr-ignored-differences.xml +++ b/google-cloud-spanner/clirr-ignored-differences.xml @@ -597,16 +597,6 @@ com/google/cloud/spanner/StructReader java.util.List getIntervalList(java.lang.String) - - 7013 - com/google/cloud/spanner/AbstractStructReader - com.google.cloud.spanner.Interval getIntervalInternal(int) - - - 7013 - com/google/cloud/spanner/AbstractStructReader - java.util.List getIntervalListInternal(int) - 7013 com/google/cloud/spanner/Value