Skip to content
This repository was archived by the owner on Sep 5, 2023. It is now read-only.

docs(samples): Added sample for creating Secret with UserManaged replication #328

Merged
merged 9 commits into from
Aug 24, 2022
Merged

docs(samples): Added sample for creating Secret with UserManaged replication #328

merged 9 commits into from
Aug 24, 2022
+76 −0

Conversation

kapishps
Copy link
Contributor

@kapishps kapishps commented Jul 25, 2022 •
edited
Loading

Added sample for creating Secret with UserManaged replication

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes b/222386112

@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Jul 25, 2022 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: secretmanager Issues related to the googleapis/python-secret-manager API. samples Issues that are directly related to samples. labels Jul 25, 2022
@kapishps kapishps changed the title docs(secretmanager): Added sample for creating Secret with UserManaged replication docs(samples): Added sample for creating Secret with UserManaged replication Jul 25, 2022
underscoreanuj
underscoreanuj approved these changes Jul 28, 2022
View reviewed changes
Copy link

@underscoreanuj underscoreanuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

please update the copyright header to 2022, will be flagged.

parthea
parthea reviewed Aug 2, 2022
View reviewed changes
@parthea parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Aug 2, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 2, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 2, 2022
@kapishps
Copy link
Contributor Author

@parthea please approve if no other change needs to be done.

@parthea parthea merged commit c5fe7ff into googleapis:main Aug 24, 2022
@release-please release-please bot mentioned this pull request Aug 24, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@parthea parthea parthea approved these changes

@underscoreanuj underscoreanuj underscoreanuj approved these changes

Assignees
No one assigned
Labels
api: secretmanager Issues related to the googleapis/python-secret-manager API. samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kapishps @parthea @underscoreanuj @yoshi-kokoro