address review comments

Author: bharat-rajani

.gitignore

@@ -1,5 +1 @@
 coverage.coverprofile
-
-# IDE Metadata
-.idea
-.vscode

cookie_go111_test.go

@@ -17,6 +17,7 @@ func TestNewCookieFromOptionsSameSite(t *testing.T) {
 		{http.SameSiteDefaultMode},
 		{http.SameSiteLaxMode},
 		{http.SameSiteStrictMode},
+		{http.SameSiteNoneMode},
 	}
 	for i, v := range tests {
 		options := &Options{

sessions_test.go

@@ -40,8 +40,8 @@ func TestFlashes(t *testing.T) {
 
 	store := NewCookieStore([]byte("secret-key"))
 
-	if store.Options.SameSite != http.SameSiteLaxMode {
-		t.Fatalf("cookie store error: default same site is not set to Lax")
+	if store.Options.SameSite != http.SameSiteNoneMode {
+		t.Fatalf("cookie store error: default same site is not set to None")
 	}
 
 	// Round 1 ----------------------------------------------------------------
@@ -72,8 +72,8 @@ func TestFlashes(t *testing.T) {
 		t.Fatal("No cookies. Header:", hdr)
 	}
 
-	if !strings.Contains(cookies[0], "SameSite=Lax") {
-		t.Fatal("Set-Cookie does not contains SameSite=Lax, cookie string:", cookies[0])
+	if !strings.Contains(cookies[0], "SameSite=None") || !strings.Contains(cookies[0], "Secure") {
+		t.Fatal("Set-Cookie does not contains SameSite=None with Secure, cookie string:", cookies[0])
 	}
 
 	if _, err = store.Get(req, "session:key"); err.Error() != "sessions: invalid character in cookie name: session:key" {

store.go

@@ -56,7 +56,8 @@ func NewCookieStore(keyPairs ...[]byte) *CookieStore {
 		Options: &Options{
 			Path:     "/",
 			MaxAge:   86400 * 30,
-			SameSite: http.SameSiteLaxMode,
+			SameSite: http.SameSiteNoneMode,
+			Secure:   true,
 		},
 	}