fix(helm): allow special char in chart repo name (#1366)

feat: allow special char in repo name

Author: gaelreyrol

pkg/helm/charts.go

@@ -12,9 +12,10 @@ import (
 )
 
 var (
-	// https://regex101.com/r/7xFFtU/3
-	chartExp = regexp.MustCompile(`^(?P<chart>\w+\/.+)@(?P<version>[^:\n\s]+)(?:\:(?P<path>[\w-. ]+))?$`)
-	repoExp  = regexp.MustCompile(`^\w+$`)
+	// https://regex101.com/r/9m42pQ/1
+	chartExp = regexp.MustCompile(`^(?P<chart>[\w+-\/.]+)@(?P<version>[^:\n\s]+)(?:\:(?P<path>[\w-. ]+))?$`)
+	// https://regex101.com/r/xoAx8c/1
+	repoExp = regexp.MustCompile(`^[\w-]+$`)
 )
 
 // LoadChartfile opens a Chartfile tree

pkg/helm/charts_test.go

@@ -50,6 +50,15 @@ func TestParseReq(t *testing.T) {
 			input: "https://helm.releases.hashicorp.com/[email protected]",
 			err:   errors.New("not of form 'repo/chart@version(:path)' where repo contains no special characters"),
 		},
+		{
+			name:  "repo-with-special-chars",
+			input: "with-dashes/[email protected]",
+			expected: &Requirement{
+				Chart:     "with-dashes/package",
+				Version:   "1.0.0",
+				Directory: "",
+			},
+		},
 	}
 
 	for _, tc := range testCases {
@@ -68,12 +77,13 @@ func TestAddRepos(t *testing.T) {
 	err = c.AddRepos(
 		Repo{Name: "foo", URL: "https://foo.com"},
 		Repo{Name: "foo2", URL: "https://foo2.com"},
+		Repo{Name: "with-dashes", URL: "https://foo.com"},
 	)
 	assert.NoError(t, err)
 
-	// Only \w characters are allowed in repo names
+	// Only \w- characters are allowed in repo names
 	err = c.AddRepos(
-		Repo{Name: "with-dashes", URL: "https://foo.com"},
+		Repo{Name: "re:po", URL: "https://foo.com"},
 	)
 	assert.EqualError(t, err, "1 Repo(s) were skipped. Please check above logs for details")