Skip to content

fix(drivers-vector): don't mutate same instance of meta #1782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

collindutter
Copy link
Member

Describe your changes

Problem:

Specifying a meta object with upsert_text_artifacts caused all underlying calls to upsert_text_artifact to share the same meta instance.

Solution

Create a new instance of meta before inserting artifact.

Issue ticket number and link

Closes #1781

@collindutter collindutter requested a review from a team February 28, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Race condition when using upsert_text_artifacts with the meta kwarg to upsert multiple chunks
2 participants