Skip to content

[FT] Add tests for VLLMModel base methods #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
NathanHB opened this issue May 15, 2025 · 0 comments
Open

[FT] Add tests for VLLMModel base methods #724

NathanHB opened this issue May 15, 2025 · 0 comments
Assignees
@NathanHB
Labels
feature/enhancement New feature/request good first issue Good for newcomers

Comments

@NathanHB
Copy link
Member

Issue encountered

From @lewtun: in addition to adding integration tests for the vllm backend of lighteval WDYT about prioritising some unit tests for the VLLMModel class methods? That would help catch subtle bugs like this and also protect us a bit from silent, yet breaking changes on the vllm side

Solution/Feature

Add tests for VLLMModel
@NathanHB NathanHB added good first issue Good for newcomers feature/enhancement New feature/request labels May 15, 2025
@NathanHB NathanHB self-assigned this May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NathanHB NathanHB

Labels
feature/enhancement New feature/request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NathanHB