Best practices about DataProtection setup

[sprudel79]

Hi everyone,
I am wondering how to properly configure the DataProtection when storing the data in Redis and using "PersistKeysToStackExchangeRedis" extension. Right now I use this:

public void ConfigureServices(IServiceCollection services)
{
    ...    
    // Init DataProtection
    _ = services.AddDataProtection()
        .PersistKeysToStackExchangeRedis(() => 
            {
                var sp = services.BuildServiceProvider();
                return sp.GetRequiredService<IRedisDatabase>().Database;
            }, key);
    ...
}

IRedisDatabase is defined as a singleton in AddStackExchangeRedisExtensions:

services.AddSingleton((provider) => provider
            .GetRequiredService<IRedisClientFactory>()
            .GetDefaultRedisClient()
            .GetDefaultDatabase());

Alternatively, I also have this way to retrieve a IDatabase instance:

  var sp = services.BuildServiceProvider();
  var redisCacheClient = sp.GetRequiredService<IRedisCacheClient>();
  return redisCacheClient.GetDefaultDatabase().Database;

So I am unsure if this is the correct approach? Especially the fact I am using "BuildServiceProvider" to create a new ServiceProvider gives me a bad feeling about this. Thanks in advance for any kind of advice.

[sprudel79]

In the meantime I have checked my setup by extending the instance behind IRedisClientFactory with a simple Guid property to verify in different situations if I am really working with a single instance due to the use of the new ServiceProvider instance.
As assumed I do get different Guids.
My approach is therefore currently to create the new ServiceProvider instance after the definition of the IRedisClientFactory singleton, to create a single instance directly of the IRedisClientFactory which I use also for the DataProtection part.
Besides I overwrite directly the singleton definition of IRedisClientFactory by returning the just created instance.
Of course I need to dispose this instance by myself but now I am working in both DataProtection and Service context with exactly the same instance of IRedisClientFactory.

[LeaFrock]

It's not recommended to use BuildServiceProvider manually.

Why not just create a standalone ConnectionMultiplexer or IDatabase for it?

        private static void AddDataProtectionRedis(this IServiceCollection services, IConfiguration configuration)
        {
            var redisConf = configuration.GetSection("Redis").Get<RedisConfiguration>();
            var redisConnStr = redisConf.ConfigurationOptions.ToString();
            var conn = ConnectionMultiplexer.Connect(redisConnStr);
            var redisDb = conn.GetDatabase(redisConf.Database);
            services.AddDataProtection()
                .SetApplicationName("MyApp")
                .PersistKeysToStackExchangeRedis(() => redisDb, "MyApp-DataProtection-Keys");
        }