Skip to content

Commit db1db99

Browse files
authored
[SYCL][NFC] Update Attribute Document (#3102)
We removed the following restrictions on #1878 // Allow the following kernel attributes only on lambda functions and // function objects that are called directly from a kernel (i.e. the one // passed to the parallel_for function). For all other cases, // emit a warning and ignore. 1. SYCLIntelKernelArgsRestrictAttr 2. SYCLIntelNumSimdWorkItemsAttr 3. SYCLIntelMaxWorkGroupSizeAttr 4. SYCLIntelMaxGlobalWorkDimAttr This patch updates the attribute document to reflect the changes since we do not ignore the kernel attributes anymore if it is applied to a function called from a device kernel and the attribute gets propagated to a kernel. Signed-off-by: Soumi Manna <[email protected]>
1 parent ec6fbe1 commit db1db99

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

clang/include/clang/Basic/AttrDocs.td

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2199,7 +2199,7 @@ attribute was applied. This effect is equivalent to annotating restrict on
21992199
**all** kernel pointer arguments in an OpenCL or SPIR-V kernel.
22002200

22012201
If ``intel::kernel_args_restrict`` is applied to a function called from a device
2202-
kernel, the attribute is ignored and it is not propagated to a kernel.
2202+
kernel, the attribute is not ignored and it is propagated to the kernel.
22032203

22042204
The attribute forms an unchecked assertion, in that implementations
22052205
do not need to check/confirm the pre-condition in any way. If a user applies
@@ -2229,7 +2229,7 @@ def SYCLIntelNumSimdWorkItemsAttrDocs : Documentation {
22292229
Applies to a device function/lambda function. Indicates the number of work
22302230
items that should be processed in parallel. Valid values are positive integers.
22312231
If ``intel::num_simd_work_items`` is applied to a function called from a
2232-
device kernel, the attribute is ignored and it is not propagated to a kernel.
2232+
device kernel, the attribute is not ignored and it is propagated to the kernel.
22332233
}];
22342234
}
22352235

@@ -2243,7 +2243,7 @@ clusters handle stalls using a stall-enable signal to freeze computation
22432243
within the cluster. This attribute is ignored on the host.
22442244

22452245
If ``intel::use_stall_enable_clusters`` is applied to a function called from a device
2246-
kernel, the attribute is ignored and it is not propagated to a kernel.
2246+
kernel, the attribute is ignored and it is not propagated to the kernel.
22472247

22482248
The ``intel::use_stall_enable_clusters`` attribute takes no argument and has an effect
22492249
when applied to a function, and no effect otherwise.
@@ -2305,7 +2305,7 @@ of a work group. Values must be positive integers. This is similar to
23052305
reqd_work_group_size, but allows work groups that are smaller or equal to the
23062306
specified sizes.
23072307
If ``intel::max_work_group_size`` is applied to a function called from a
2308-
device kernel, the attribute is ignored and it is not propagated to a kernel.
2308+
device kernel, the attribute is not ignored and it is propagated to the kernel.
23092309
}];
23102310
}
23112311

@@ -2321,7 +2321,7 @@ range of [0, 3]. A kernel with max_global_work_dim(0) must be invoked with a
23212321
``cl::reqd_work_group_size`` are applied to the kernel as well - they shall
23222322
have arguments of (1, 1, 1).
23232323
If ``intel::max_global_work_dim`` is applied to a function called from a
2324-
device kernel, the attribute is ignored and it is not propagated to a kernel.
2324+
device kernel, the attribute is not ignored and it is propagated to the kernel.
23252325
}];
23262326
}
23272327

0 commit comments

Comments
 (0)