don't set token for private single npm packages

Author: hipstersmoothie

plugins/npm/__tests__/set-npm-token.test.ts

@@ -7,6 +7,7 @@ import * as utils from "../src/utils";
 const loadPackageJson = utils.loadPackageJson as jest.Mock;
 const readFile = utils.readFile as jest.Mock;
 const writeFile = utils.writeFile as jest.Mock;
+const isMonorepo = utils.isMonorepo as jest.Mock;
 
 jest.mock("../src/utils.ts");
 jest.mock("env-ci", () => () => ({
@@ -31,6 +32,23 @@ describe("set npm token", () => {
     );
   });
 
+  test("should not write a new npmrc for single private package", async () => {
+    loadPackageJson.mockReturnValueOnce({ name: "test", private: true });
+    isMonorepo.mockReturnValueOnce(false);
+
+    await setNpmToken(dummyLog());
+    expect(writeFile).not.toHaveBeenCalled()
+  });
+
+
+  test("should write a npmrc for monorepo", async () => {
+    loadPackageJson.mockReturnValueOnce({ name: "test", private: true });
+    isMonorepo.mockReturnValueOnce(true);
+
+    await setNpmToken(dummyLog());
+    expect(writeFile).toHaveBeenCalled()
+  });
+
   test("should write a new npmrc w/o name", async () => {
     loadPackageJson.mockReturnValueOnce({});
     await setNpmToken(dummyLog());
@@ -52,7 +70,7 @@ describe("set npm token", () => {
     );
   });
 
-  test("should use registry for scoped pacakged", async () => {
+  test("should use registry for scoped packaged", async () => {
     loadPackageJson.mockReturnValueOnce({
       name: "@scope/test",
     });

plugins/npm/src/index.ts

@@ -26,14 +26,11 @@ import { gt, gte, inc, ReleaseType } from "semver";
 
 import getConfigFromPackageJson from "./package-config";
 import setTokenOnCI from "./set-npm-token";
-import { loadPackageJson, writeFile } from "./utils";
+import { loadPackageJson, writeFile, isMonorepo } from "./utils";
 
 const { isCi } = envCi();
 const VERSION_COMMIT_MESSAGE = '"Bump version to: %s [skip ci]"';
 
-/** Check if the project is a monorepo */
-const isMonorepo = () => fs.existsSync("lerna.json");
-
 /** Get the last published version for a npm package */
 async function getPublishedVersion(name: string) {
   try {

plugins/npm/src/set-npm-token.ts

@@ -5,7 +5,7 @@ import registryUrl from "registry-url";
 import urlJoin from "url-join";
 import userHome from "user-home";
 
-import { loadPackageJson, readFile, writeFile } from "./utils";
+import { loadPackageJson, readFile, writeFile, isMonorepo } from "./utils";
 
 const { isCi } = envCi();
 
@@ -15,7 +15,13 @@ export default async function setTokenOnCI(logger: ILogger) {
     return;
   }
 
-  const { publishConfig = {}, name } = await loadPackageJson();
+  const { publishConfig = {}, name, private: isPrivate } = await loadPackageJson();
+
+  if (isPrivate && !isMonorepo()) {
+    logger.verbose.info('NPM token not set for private package.')
+    return;
+  }
+
   const rc = path.join(userHome, ".npmrc");
   let contents = "";
 

plugins/npm/src/utils.ts

@@ -9,3 +9,6 @@ export const writeFile = promisify(fs.writeFile);
 export async function loadPackageJson(root = "./"): Promise<IPackageJSON> {
   return JSON.parse(await readFile(path.join(root, "package.json"), "utf-8"));
 }
+
+/** Check if the project is a monorepo */
+export const isMonorepo = () => fs.existsSync("lerna.json");