Skip to content

Commit 7a5d085

Browse files
authored
resolve issue #1926 (unnecessary dependencies) (#1927)
* buildscript: move def of "niftyVersion" to "common.gradle" (shared between projects) * jme3-testdata: rm dependency on "nifty-style-black" (redundant with "jme3-niftygui") * buildscript: mv "nifty-examples" dependency from "jme3-testdata" to "jme3-examples"
1 parent ead32f1 commit 7a5d085

File tree

4 files changed

+2
-6
lines changed

4 files changed

+2
-6
lines changed

common.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ tasks.withType(JavaCompile) { // compile-time options:
2727

2828
ext {
2929
lwjgl3Version = '3.3.1' // used in both the jme3-lwjgl3 and jme3-vr build scripts
30+
niftyVersion = '1.4.3' // used in both the jme3-niftygui and jme3-examples build scripts
3031
}
3132

3233
repositories {

jme3-examples/build.gradle

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ dependencies {
2727
implementation project(':jme3-terrain')
2828
implementation project(':jme3-awt-dialogs')
2929
runtimeOnly project(':jme3-testdata')
30+
runtimeOnly "com.github.nifty-gui:nifty-examples:${niftyVersion}" // for the "all/intro.xml" example GUI
3031
}
3132

3233
jar.doFirst{

jme3-niftygui/build.gradle

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
def niftyVersion = '1.4.3'
2-
31
dependencies {
42
api project(':jme3-core')
53
api "com.github.nifty-gui:nifty:${niftyVersion}"

jme3-testdata/build.gradle

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,2 @@
1-
def niftyVersion = '1.4.3'
2-
31
dependencies {
4-
runtimeOnly "com.github.nifty-gui:nifty-examples:$niftyVersion"
5-
runtimeOnly "com.github.nifty-gui:nifty-style-black:$niftyVersion"
62
}

0 commit comments

Comments
 (0)