Skip to content

Commit 9cc788e

Browse files
Revert "add x86_64 arm64-v8a support. Fixes facebook#2814 (facebook#18754)"
This reverts commit 0a2825f.
1 parent 76356cf commit 9cc788e

File tree

8 files changed

+28
-12
lines changed

8 files changed

+28
-12
lines changed

RNTester/android/app/build.gradle

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ apply from: "../../../react.gradle"
7676
* Upload all the APKs to the Play Store and people will download
7777
* the correct one based on the CPU architecture of their device.
7878
*/
79-
def enableSeparateBuildPerCPUArchitecture = true
79+
def enableSeparateBuildPerCPUArchitecture = false
8080

8181
/**
8282
* Run Proguard to shrink the Java bytecode in release builds.
@@ -93,6 +93,9 @@ android {
9393
targetSdkVersion 27
9494
versionCode 1
9595
versionName "1.0"
96+
ndk {
97+
abiFilters "armeabi-v7a", "x86"
98+
}
9699
}
97100
signingConfigs {
98101
release {
@@ -107,7 +110,7 @@ android {
107110
enable enableSeparateBuildPerCPUArchitecture
108111
universalApk false
109112
reset()
110-
include "armeabi-v7a", "x86", "x86_64", "arm64-v8a"
113+
include "armeabi-v7a", "x86"
111114
}
112115
}
113116
buildTypes {
@@ -120,6 +123,20 @@ android {
120123
signingConfig signingConfigs.release
121124
}
122125
}
126+
127+
// applicationVariants are e.g. debug, release
128+
applicationVariants.all { variant ->
129+
variant.outputs.each { output ->
130+
// For each separate APK per architecture, set a unique version code as described here:
131+
// http://tools.android.com/tech-docs/new-build-system/user-guide/apk-splits
132+
def versionCodes = ["armeabi-v7a":1, "x86":2]
133+
def abi = output.getFilter(OutputFile.ABI)
134+
if (abi != null) { // null for the universal-debug, universal-release variants
135+
output.versionCodeOverride =
136+
versionCodes.get(abi) * 1048576 + defaultConfig.versionCode
137+
}
138+
}
139+
}
123140
}
124141

125142
dependencies {

ReactAndroid/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -304,7 +304,7 @@ dependencies {
304304
api "com.squareup.okhttp3:okhttp:${OKHTTP_VERSION}"
305305
api "com.squareup.okhttp3:okhttp-urlconnection:${OKHTTP_VERSION}"
306306
api 'com.squareup.okio:okio:1.14.0'
307-
compile project(':android-jsc')
307+
compile 'org.webkit:android-jsc:r174650'
308308

309309
testImplementation "junit:junit:${JUNIT_VERSION}"
310310
testImplementation "org.powermock:powermock-api-mockito:${POWERMOCK_VERSION}"

ReactAndroid/src/main/jni/Application.mk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
APP_BUILD_SCRIPT := Android.mk
22

3-
APP_ABI := armeabi-v7a x86 arm64-v8a x86_64
3+
APP_ABI := armeabi-v7a x86
44
APP_PLATFORM := android-16
55

66
APP_MK_DIR := $(dir $(lastword $(MAKEFILE_LIST)))

ReactAndroid/src/main/jni/third-party/double-conversion/Android.mk

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,4 @@ LOCAL_EXPORT_C_INCLUDES := $(LOCAL_PATH)
1919
CXX11_FLAGS := -Wno-unused-variable -Wno-unused-local-typedefs
2020
LOCAL_CFLAGS += $(CXX11_FLAGS)
2121

22-
include $(BUILD_STATIC_LIBRARY)
22+
include $(BUILD_STATIC_LIBRARY)

android-jsc/android-jsc.aar

-7.97 MB
Binary file not shown.

android-jsc/build.gradle

Lines changed: 0 additions & 2 deletions
This file was deleted.

local-cli/templates/HelloWorld/android/app/build.gradle

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,13 +103,16 @@ android {
103103
targetSdkVersion rootProject.ext.targetSdkVersion
104104
versionCode 1
105105
versionName "1.0"
106+
ndk {
107+
abiFilters "armeabi-v7a", "x86"
108+
}
106109
}
107110
splits {
108111
abi {
109112
reset()
110113
enable enableSeparateBuildPerCPUArchitecture
111114
universalApk false // If true, also generate a universal APK
112-
include "armeabi-v7a", "x86", "arm64-v8a"
115+
include "armeabi-v7a", "x86"
113116
}
114117
}
115118
buildTypes {
@@ -123,7 +126,7 @@ android {
123126
variant.outputs.each { output ->
124127
// For each separate APK per architecture, set a unique version code as described here:
125128
// http://tools.android.com/tech-docs/new-build-system/user-guide/apk-splits
126-
def versionCodes = ["armeabi-v7a":1, "x86":2, "arm64-v8a": 3]
129+
def versionCodes = ["armeabi-v7a":1, "x86":2]
127130
def abi = output.getFilter(OutputFile.ABI)
128131
if (abi != null) { // null for the universal-debug, universal-release variants
129132
output.versionCodeOverride =

settings.gradle

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,4 @@
33
// This source code is licensed under the MIT license found in the
44
// LICENSE file in the root directory of this source tree.
55

6-
include ':ReactAndroid'
7-
include ':RNTester:android:app'
8-
include ':android-jsc'
6+
include ':ReactAndroid', ':RNTester:android:app'

0 commit comments

Comments
 (0)