Add nullcheck to eliminate warning with Code Analysis

alexkaratarakis · alexkaratarakis · commit 944daa78f76d · 2016-06-02T18:53:37.000-07:00
diff --git a/Release/src/utilities/asyncrt_utils.cpp b/Release/src/utilities/asyncrt_utils.cpp
@@ -63,7 +63,7 @@ scoped_c_thread_locale::xplat_locale scoped_c_thread_locale::c_locale()
         scoped_c_thread_locale::xplat_locale *clocale = new scoped_c_thread_locale::xplat_locale();
 #ifdef _WIN32
         *clocale = _create_locale(LC_ALL, "C");
-        if (*clocale == nullptr)
+        if (clocale == nullptr || *clocale == nullptr)
         {
             throw std::runtime_error("Unable to create 'C' locale.");
         }
@@ -74,7 +74,7 @@ scoped_c_thread_locale::xplat_locale scoped_c_thread_locale::c_locale()
         };
 #else
         *clocale = newlocale(LC_ALL, "C", nullptr);
-        if (*clocale == nullptr)
+        if (clocale == nullptr || *clocale == nullptr)
         {
             throw std::runtime_error("Unable to create 'C' locale.");
         }

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ scoped_c_thread_locale::xplat_locale scoped_c_thread_locale::c_locale()`
`63`	`63`	`scoped_c_thread_locale::xplat_locale *clocale = new scoped_c_thread_locale::xplat_locale();`
`64`	`64`	`#ifdef _WIN32`
`65`	`65`	`*clocale = _create_locale(LC_ALL, "C");`
`66`		`- if (*clocale == nullptr)`
	`66`	`+ if (clocale == nullptr \|\| *clocale == nullptr)`
`67`	`67`	`{`
`68`	`68`	`throw std::runtime_error("Unable to create 'C' locale.");`
`69`	`69`	`}`
`@@ -74,7 +74,7 @@ scoped_c_thread_locale::xplat_locale scoped_c_thread_locale::c_locale()`
`74`	`74`	`};`
`75`	`75`	`#else`
`76`	`76`	`*clocale = newlocale(LC_ALL, "C", nullptr);`
`77`		`- if (*clocale == nullptr)`
	`77`	`+ if (clocale == nullptr \|\| *clocale == nullptr)`
`78`	`78`	`{`
`79`	`79`	`throw std::runtime_error("Unable to create 'C' locale.");`
`80`	`80`	`}`