Merge pull request unoplatform#9954 from Youssef1313/cleanup-build

build: Remove unnecessary roslyn-override.targets and fix related build warnings

Author: MartinZikmund

build/ci/.azure-devops-samplesapp-uitests-build.yml

@@ -33,7 +33,7 @@ jobs:
     displayName: 'Build UI Tests'
     inputs:
       solution: src/SamplesApp/SamplesApp.UITests/SamplesApp.UITests.csproj
-      msbuildArguments: /r /m /p:Configuration=Release /p:MicrosoftNetCompilerVersionOverride=4.0.1 /detailedsummary /m /bl:$(build.artifactstagingdirectory)\build.binlog
+      msbuildArguments: /r /m /p:Configuration=Release /detailedsummary /m /bl:$(build.artifactstagingdirectory)\build.binlog
 
   - task: CopyFiles@2
     displayName: 'Publish Wasm UITest binaries'

src/Common.targets

@@ -20,8 +20,4 @@
 		</PropertyGroup>
 
 	</Target>
-
-	<!-- Import the override as the nuget tooling in VS is skipping ItemGroup conditions for legacy projects -->
-	<Import Project="roslyn-override.targets" Condition="'$(MicrosoftNetCompilerVersionOverride)'!=''"/>
-
 </Project>

src/Directory.Build.targets

@@ -131,8 +131,21 @@
 	  <MicrosoftNetCompilerVersionOverride>4.4.0-2.final</MicrosoftNetCompilerVersionOverride>
   </PropertyGroup>
 
-  <!-- Import the override as the nuget tooling in VS is skipping ItemGroup conditions for legacy projects -->
-  <Import Project="roslyn-override.targets" Condition="'$(MicrosoftNetCompilerVersionOverride)'!=''"/>
+  <PropertyGroup>
+	<!--
+	    Disable shared compilation for the override to take place
+	    https://github.com/dotnet/roslyn/blob/315c2e149ba7889b0937d872274c33fcbfe9af5f/src/NuGet/Microsoft.Net.Compilers/build/Microsoft.Net.Compilers.props#L36
+	-->
+    <UseSharedCompilation>false</UseSharedCompilation>
+  </PropertyGroup>
+
+  <ItemGroup>
+    <!--This override is used to validate the use of specific version of the C# Compiler-->
+    <PackageReference Include="Microsoft.Net.Compilers.Toolset" Version="$(MicrosoftNetCompilerVersionOverride)">
+      <PrivateAssets>all</PrivateAssets>
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
+    </PackageReference>
+  </ItemGroup>
 
   <Target Name="WorkaroundMissingWinAppSDKDLL"
 				  BeforeTargets="BinPlaceBootstrapDll">