add comment explaining why GPG check is kept in RewordCommit

m04f · m04f · commit a676f6fbad80 · 2025-06-29T18:55:11.000+03:00
diff --git a/pkg/commands/git_commands/rebase.go b/pkg/commands/git_commands/rebase.go
@@ -35,6 +35,8 @@ func NewRebaseCommands(
 }
 
 func (self *RebaseCommands) RewordCommit(commits []*models.Commit, index int, summary string, description string) error {
+	// This check is currently unreachable (handled in LocalCommitsController.reword),
+	// but kept as a safeguard in case this method is used elsewhere.
 	if self.config.NeedsGpgSubprocessForCommit() {
 		return errors.New(self.Tr.DisabledForGPG)
 	}

Original file line number	Diff line number	Diff line change
`@@ -35,6 +35,8 @@ func NewRebaseCommands(`
`35`	`35`	`}`
`36`	`36`
`37`	`37`	`func (self RebaseCommands) RewordCommit(commits []models.Commit, index int, summary string, description string) error {`
	`38`	`+ // This check is currently unreachable (handled in LocalCommitsController.reword),`
	`39`	`+ // but kept as a safeguard in case this method is used elsewhere.`
`38`	`40`	`if self.config.NeedsGpgSubprocessForCommit() {`
`39`	`41`	`return errors.New(self.Tr.DisabledForGPG)`
`40`	`42`	`}`