Skip to content

Commit 0bb9982

Browse files
Jeff PeelerVille Aikas
Jeff Peeler
authored and
Ville Aikas
committed
Modify Makefile to only specify ldflags once (openshift#1471)
They are not cumulative, so latter ldflags will cause the previous ones to not be set. In this case, that caused the version information to not be set as expected. Closes openshift#1469
1 parent 5d6afac commit 0bb9982

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

Makefile

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,7 @@ $(error Unsupported platform to compile for)
7474
endif
7575

7676
GO_BUILD = env GOOS=$(PLATFORM) GOARCH=$(ARCH) go build -i $(GOFLAGS) \
77-
-ldflags "-X $(SC_PKG)/pkg.VERSION=$(VERSION)" \
78-
-ldflags "$(BUILD_LDFLAGS)"
77+
-ldflags "-X $(SC_PKG)/pkg.VERSION=$(VERSION) $(BUILD_LDFLAGS)"
7978
BASE_PATH = $(ROOT:/src/github.com/kubernetes-incubator/service-catalog/=)
8079
export GOPATH = $(BASE_PATH):$(ROOT)/vendor
8180

0 commit comments

Comments
 (0)