Wrap bare EINVAL returns with SET_ERROR

Ryan Moeller · jsai20 · commit c402075fe4ae · 2021-03-30T05:14:54.000Z
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ryan Moeller <ryan@iXsystems.com> Closes openzfs#11636
diff --git a/module/zfs/zfs_ioctl.c b/module/zfs/zfs_ioctl.c
@@ -3986,7 +3986,7 @@ zfs_ioc_pool_initialize(const char *poolname, nvlist_t *innvl, nvlist_t *outnvl)
 	fnvlist_free(vdev_errlist);
 
 	spa_close(spa, FTAG);
-	return (total_errors > 0 ? EINVAL : 0);
+	return (total_errors > 0 ? SET_ERROR(EINVAL) : 0);
 }
 
 /*
@@ -4071,7 +4071,7 @@ zfs_ioc_pool_trim(const char *poolname, nvlist_t *innvl, nvlist_t *outnvl)
 	fnvlist_free(vdev_errlist);
 
 	spa_close(spa, FTAG);
-	return (total_errors > 0 ? EINVAL : 0);
+	return (total_errors > 0 ? SET_ERROR(EINVAL) : 0);
 }
 
 /*

Original file line number	Diff line number	Diff line change
`@@ -3986,7 +3986,7 @@ zfs_ioc_pool_initialize(const char poolname, nvlist_t innvl, nvlist_t *outnvl)`
`3986`	`3986`	`fnvlist_free(vdev_errlist);`
`3987`	`3987`
`3988`	`3988`	`spa_close(spa, FTAG);`
`3989`		`- return (total_errors > 0 ? EINVAL : 0);`
	`3989`	`+ return (total_errors > 0 ? SET_ERROR(EINVAL) : 0);`
`3990`	`3990`	`}`
`3991`	`3991`
`3992`	`3992`	`/*`
`@@ -4071,7 +4071,7 @@ zfs_ioc_pool_trim(const char poolname, nvlist_t innvl, nvlist_t *outnvl)`
`4071`	`4071`	`fnvlist_free(vdev_errlist);`
`4072`	`4072`
`4073`	`4073`	`spa_close(spa, FTAG);`
`4074`		`- return (total_errors > 0 ? EINVAL : 0);`
	`4074`	`+ return (total_errors > 0 ? SET_ERROR(EINVAL) : 0);`
`4075`	`4075`	`}`
`4076`	`4076`
`4077`	`4077`	`/*`