[Fix] no-this-in-sfc: Fix false positive on SFC defined as object property

Fixes #2147

Author: Yannick Croissant

lib/rules/no-this-in-sfc.js

@@ -31,7 +31,7 @@ module.exports = {
     MemberExpression(node) {
       if (node.object.type === 'ThisExpression') {
         const component = components.get(utils.getParentStatelessComponent());
-        if (!component) {
+        if (!component || component.node && component.node.parent && component.node.parent.type === 'Property') {
           return;
         }
         context.report({

tests/lib/rules/no-this-in-sfc.js

@@ -137,6 +137,17 @@ ruleTester.run('no-this-in-sfc', rule, {
       };
     }`,
     parser: 'babel-eslint'
+  }, {
+    code: `
+    export const Example = ({ prop }) => {
+      return {
+        handleClick: () => {},
+        renderNode() {
+          return <div onClick={this.handleClick} />;
+        },
+      };
+    };`,
+    parser: 'babel-eslint'
   }],
   invalid: [{
     code: `