Skip to content

Require the same version we replace for prometheus #6806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2025

Conversation

GraceAtwood
Copy link
Contributor

@GraceAtwood GraceAtwood commented May 30, 2025

hey yall! We recently took a dependency on github.com/kedacore/keda/v2

But that's now causing all our IDEs to break with

go list -modfile=go.mod -m -json -mod=mod all
go: [github.com/prometheus/[email protected]](http://github.com/prometheus/[email protected]): invalid version: unknown revision 000000000000

seems like it's due to this line here

keda/go.mod

Line 80 in e23ef46

github.com/prometheus/prometheus v0.0.0-00010101000000-000000000000

I asked that ^ question in Slack and @JorTurFer asked that I open this PR

Provide a description of what has been changed

So this just changes the require line to match what we're replacing so that when downstream projects take a dependency on keda, they don't import a bad version.

Checklist

Relates to #
https://kubernetes.slack.com/archives/CKZJ36A5D/p1747927855084599

@GraceAtwood GraceAtwood requested a review from a team as a code owner May 30, 2025 14:16
@GraceAtwood GraceAtwood marked this pull request as draft May 30, 2025 14:17
@GraceAtwood GraceAtwood force-pushed the atwood-require-prometheus branch from 2367af4 to 6356695 Compare May 30, 2025 14:20
@GraceAtwood GraceAtwood force-pushed the atwood-require-prometheus branch from 6356695 to bfee109 Compare May 30, 2025 14:22
@GraceAtwood GraceAtwood marked this pull request as ready for review May 30, 2025 14:29
@JorTurFer
Copy link
Member

Thanks!

@JorTurFer JorTurFer merged commit 100f234 into kedacore:main Jun 1, 2025
19 of 20 checks passed
@GraceAtwood GraceAtwood deleted the atwood-require-prometheus branch June 2, 2025 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants