Skip to content

Commit 47f39c2

Browse files
addressed pr comments
1 parent 757a333 commit 47f39c2

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

internal/matchers/matchers.go

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,8 @@ import (
2020
"bytes"
2121
"encoding/json"
2222
"fmt"
23-
"log"
2423
"reflect"
2524

26-
"github.com/davecgh/go-spew/spew"
27-
2825
jsonpatch "github.com/evanphx/json-patch"
2926
"github.com/onsi/gomega/format"
3027
"github.com/pkg/errors"
@@ -133,13 +130,12 @@ func (m *Matcher) calculateDiff(actual interface{}) ([]byte, error) {
133130
if err != nil {
134131
return nil, err
135132
}
136-
log.Print(spew.Sdump(diff))
137133

134+
// Filter the diff according to the rules attached to the Matcher.
138135
diff, err = filterDiff(diff, m.options.allowPaths, m.options.ignorePaths)
139136
if err != nil {
140137
return nil, err
141138
}
142-
log.Print(spew.Sdump(diff))
143139
return diff, nil
144140
}
145141

internal/matchers/matchers_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -310,7 +310,7 @@ func TestEqualObjectMatcher(t *testing.T) {
310310
want: true,
311311
},
312312
{
313-
name: "Unequal labels and annotations",
313+
name: "Unequal labels and annotations ignored by IgnorePaths MatchOption",
314314
original: &unstructured.Unstructured{
315315
Object: map[string]interface{}{},
316316
},

0 commit comments

Comments
 (0)