Skip to content

Commit 00ae8cb

Browse files
author
Avesh Agarwal
committed
Remove resources that are not needed to run cluster capacity analysis.
1 parent a650edb commit 00ae8cb

File tree

8 files changed

+19
-555
lines changed

8 files changed

+19
-555
lines changed

pkg/api/api.go

Lines changed: 2 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -21,19 +21,13 @@ import (
2121

2222
"k8s.io/apimachinery/pkg/runtime"
2323
"k8s.io/kubernetes/pkg/api/v1"
24-
"k8s.io/kubernetes/pkg/apis/extensions/v1beta1"
2524
)
2625

2726
type ResourceType string
2827

2928
const (
30-
Pods ResourceType = "pods"
31-
PersistentVolumes ResourceType = "persistentvolumes"
32-
ReplicationControllers ResourceType = "replicationcontrollers"
33-
Nodes ResourceType = "nodes"
34-
Services ResourceType = "services"
35-
PersistentVolumeClaims ResourceType = "persistentvolumeclaims"
36-
ReplicaSets ResourceType = "replicasets"
29+
Pods ResourceType = "pods"
30+
Nodes ResourceType = "nodes"
3731
)
3832

3933
func (r ResourceType) String() string {
@@ -44,18 +38,8 @@ func (r ResourceType) ObjectType() runtime.Object {
4438
switch r {
4539
case "pods":
4640
return &v1.Pod{}
47-
case "persistentvolumes":
48-
return &v1.PersistentVolume{}
49-
case "replicationcontrollers":
50-
return &v1.ReplicationController{}
5141
case "nodes":
5242
return &v1.Node{}
53-
case "services":
54-
return &v1.Service{}
55-
case "persistentvolumeclaims":
56-
return &v1.PersistentVolumeClaim{}
57-
case "replicasets":
58-
return &v1beta1.ReplicaSet{}
5943
}
6044
return nil
6145
}
@@ -64,18 +48,8 @@ func StringToResourceType(resource string) (ResourceType, error) {
6448
switch resource {
6549
case "pods":
6650
return Pods, nil
67-
case "persistentvolumes":
68-
return PersistentVolumes, nil
69-
case "replicationcontrollers":
70-
return ReplicationControllers, nil
7151
case "nodes":
7252
return Nodes, nil
73-
case "services":
74-
return Services, nil
75-
case "persistentvolumeclaims":
76-
return PersistentVolumeClaims, nil
77-
case "replicasets":
78-
return ReplicaSets, nil
7953
default:
8054
return "", fmt.Errorf("Resource type %v not recognized", resource)
8155
}

pkg/framework/restclient/external/restclient.go

Lines changed: 1 addition & 148 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ import (
3737
"k8s.io/client-go/util/flowcontrol"
3838
"k8s.io/kubernetes/pkg/api"
3939
"k8s.io/kubernetes/pkg/api/v1"
40-
"k8s.io/kubernetes/pkg/apis/extensions/v1beta1"
4140

4241
ccapi "github.com/kubernetes-incubator/cluster-capacity/pkg/api"
4342
"github.com/kubernetes-incubator/cluster-capacity/pkg/framework/store"
@@ -124,80 +123,6 @@ func (c *RESTClient) Pods(fieldsSelector fields.Selector) *v1.PodList {
124123
}
125124
}
126125

127-
func (c *RESTClient) Services(fieldsSelector fields.Selector) *v1.ServiceList {
128-
items := c.resourceStore.List(ccapi.Services)
129-
typedItems := make([]v1.Service, 0, len(items))
130-
for _, item := range items {
131-
if !fieldsSelector.Matches(NewObjectFieldsAccessor(item)) {
132-
continue
133-
}
134-
typedItems = append(typedItems, *item.(*v1.Service))
135-
}
136-
137-
return &v1.ServiceList{
138-
ListMeta: metav1.ListMeta{
139-
// choose arbitrary value as the cache does not store the ResourceVersion
140-
ResourceVersion: "0",
141-
},
142-
Items: typedItems,
143-
}
144-
}
145-
146-
func (c *RESTClient) ReplicationControllers(fieldsSelector fields.Selector) *v1.ReplicationControllerList {
147-
items := c.resourceStore.List(ccapi.ReplicationControllers)
148-
typedItems := make([]v1.ReplicationController, 0, len(items))
149-
for _, item := range items {
150-
if !fieldsSelector.Matches(NewObjectFieldsAccessor(item)) {
151-
continue
152-
}
153-
typedItems = append(typedItems, *item.(*v1.ReplicationController))
154-
}
155-
156-
return &v1.ReplicationControllerList{
157-
ListMeta: metav1.ListMeta{
158-
// choose arbitrary value as the cache does not store the ResourceVersion
159-
ResourceVersion: "0",
160-
},
161-
Items: typedItems,
162-
}
163-
}
164-
165-
func (c *RESTClient) PersistentVolumes(fieldsSelector fields.Selector) *v1.PersistentVolumeList {
166-
items := c.resourceStore.List(ccapi.PersistentVolumes)
167-
typedItems := make([]v1.PersistentVolume, 0, len(items))
168-
for _, item := range items {
169-
if !fieldsSelector.Matches(NewObjectFieldsAccessor(item)) {
170-
continue
171-
}
172-
typedItems = append(typedItems, *item.(*v1.PersistentVolume))
173-
}
174-
175-
return &v1.PersistentVolumeList{
176-
ListMeta: metav1.ListMeta{
177-
ResourceVersion: "0",
178-
},
179-
Items: typedItems,
180-
}
181-
}
182-
183-
func (c *RESTClient) PersistentVolumeClaims(fieldsSelector fields.Selector) *v1.PersistentVolumeClaimList {
184-
items := c.resourceStore.List(ccapi.PersistentVolumeClaims)
185-
typedItems := make([]v1.PersistentVolumeClaim, 0, len(items))
186-
for _, item := range items {
187-
if !fieldsSelector.Matches(NewObjectFieldsAccessor(item)) {
188-
continue
189-
}
190-
typedItems = append(typedItems, *item.(*v1.PersistentVolumeClaim))
191-
}
192-
193-
return &v1.PersistentVolumeClaimList{
194-
ListMeta: metav1.ListMeta{
195-
ResourceVersion: "0",
196-
},
197-
Items: typedItems,
198-
}
199-
}
200-
201126
func (c *RESTClient) Nodes(fieldsSelector fields.Selector) *v1.NodeList {
202127
items := c.resourceStore.List(ccapi.Nodes)
203128
typedItems := make([]v1.Node, 0, len(items))
@@ -216,40 +141,12 @@ func (c *RESTClient) Nodes(fieldsSelector fields.Selector) *v1.NodeList {
216141
}
217142
}
218143

219-
func (c *RESTClient) ReplicaSets(fieldsSelector fields.Selector) *v1beta1.ReplicaSetList {
220-
items := c.resourceStore.List(ccapi.ReplicaSets)
221-
typedItems := make([]v1beta1.ReplicaSet, 0, len(items))
222-
for _, item := range items {
223-
if !fieldsSelector.Matches(NewObjectFieldsAccessor(item)) {
224-
continue
225-
}
226-
typedItems = append(typedItems, *item.(*v1beta1.ReplicaSet))
227-
}
228-
229-
return &v1beta1.ReplicaSetList{
230-
ListMeta: metav1.ListMeta{
231-
ResourceVersion: "0",
232-
},
233-
Items: typedItems,
234-
}
235-
}
236-
237144
func (c *RESTClient) List(resource ccapi.ResourceType, fieldsSelector fields.Selector) (runtime.Object, error) {
238145
switch resource {
239146
case ccapi.Pods:
240147
return c.Pods(fieldsSelector), nil
241-
case ccapi.Services:
242-
return c.Services(fieldsSelector), nil
243-
case ccapi.ReplicationControllers:
244-
return c.ReplicationControllers(fieldsSelector), nil
245-
case ccapi.PersistentVolumes:
246-
return c.PersistentVolumes(fieldsSelector), nil
247-
case ccapi.PersistentVolumeClaims:
248-
return c.PersistentVolumeClaims(fieldsSelector), nil
249148
case ccapi.Nodes:
250149
return c.Nodes(fieldsSelector), nil
251-
case ccapi.ReplicaSets:
252-
return c.ReplicaSets(fieldsSelector), nil
253150
default:
254151
return nil, fmt.Errorf("Resource %s not recognized", resource)
255152
}
@@ -327,13 +224,7 @@ func (c *RESTClient) request(verb string) *restclient.Request {
327224
ns := c.NegotiatedSerializer
328225
info, _ := runtime.SerializerInfoForMediaType(ns.SupportedMediaTypes(), runtime.ContentTypeJSON)
329226

330-
var targetVersion schema.GroupVersion
331-
if c.name == "extensions" {
332-
gvr := schema.GroupVersionResource{Group: "extensions", Version: "v1beta1", Resource: "replicasets"}
333-
targetVersion = gvr.GroupVersion()
334-
} else {
335-
targetVersion = gv
336-
}
227+
targetVersion := gv
337228

338229
serializers := restclient.Serializers{
339230
Encoder: ns.EncoderForVersion(info.Serializer, gv),
@@ -364,9 +255,6 @@ func (c *RESTClient) createReadCloser(resource ccapi.ResourceType, obj runtime.O
364255
}
365256

366257
gv := v1.SchemeGroupVersion
367-
if resource == ccapi.ReplicaSets {
368-
gv = schema.GroupVersion{Group: "extensions", Version: "v1beta1"}
369-
}
370258
encoder := api.Codecs.EncoderForVersion(info.Serializer, gv)
371259
nopCloser := ioutil.NopCloser(bytes.NewReader([]byte(runtime.EncodeOrDie(encoder, obj))))
372260
return &nopCloser, nil
@@ -404,23 +292,8 @@ func (c *RESTClient) createGetReadCloser(resource ccapi.ResourceType, resourceNa
404292
case ccapi.Pods:
405293
obj = runtime.Object(item.(*v1.Pod))
406294
ns = item.(*v1.Pod).Namespace
407-
case ccapi.Services:
408-
obj = runtime.Object(item.(*v1.Service))
409-
ns = item.(*v1.Service).Namespace
410-
case ccapi.ReplicationControllers:
411-
obj = runtime.Object(item.(*v1.ReplicationController))
412-
ns = item.(*v1.ReplicationController).Namespace
413-
case ccapi.PersistentVolumes:
414-
obj = runtime.Object(item.(*v1.PersistentVolume))
415-
ns = item.(*v1.PersistentVolume).Namespace
416-
case ccapi.PersistentVolumeClaims:
417-
obj = runtime.Object(item.(*v1.PersistentVolumeClaim))
418-
ns = item.(*v1.PersistentVolumeClaim).Namespace
419295
case ccapi.Nodes:
420296
obj = runtime.Object(item.(*v1.Node))
421-
case ccapi.ReplicaSets:
422-
obj = runtime.Object(item.(*v1beta1.ReplicaSet))
423-
ns = item.(*v1beta1.ReplicaSet).Namespace
424297
default:
425298
return nil, fmt.Errorf("Resource %v not recognized", resource)
426299
}
@@ -459,30 +332,10 @@ func (c *RESTClient) createWatchReadCloser(resource ccapi.ResourceType, fieldsSe
459332
for _, item := range c.Pods(fieldsSelector).Items {
460333
rg.EmitWatchEvent(watch.Added, runtime.Object(&item))
461334
}
462-
case ccapi.Services:
463-
for _, item := range c.Services(fieldsSelector).Items {
464-
rg.EmitWatchEvent(watch.Added, runtime.Object(&item))
465-
}
466-
case ccapi.ReplicationControllers:
467-
for _, item := range c.ReplicationControllers(fieldsSelector).Items {
468-
rg.EmitWatchEvent(watch.Added, runtime.Object(&item))
469-
}
470-
case ccapi.PersistentVolumes:
471-
for _, item := range c.PersistentVolumes(fieldsSelector).Items {
472-
rg.EmitWatchEvent(watch.Added, runtime.Object(&item))
473-
}
474-
case ccapi.PersistentVolumeClaims:
475-
for _, item := range c.PersistentVolumeClaims(fieldsSelector).Items {
476-
rg.EmitWatchEvent(watch.Added, runtime.Object(&item))
477-
}
478335
case ccapi.Nodes:
479336
for _, item := range c.Nodes(fieldsSelector).Items {
480337
rg.EmitWatchEvent(watch.Added, runtime.Object(&item))
481338
}
482-
case ccapi.ReplicaSets:
483-
for _, item := range c.ReplicaSets(fieldsSelector).Items {
484-
rg.EmitWatchEvent(watch.Added, runtime.Object(&item))
485-
}
486339
default:
487340
return nil, fmt.Errorf("Resource %s not recognized", resource)
488341
}

0 commit comments

Comments
 (0)