Skip to content

Commit fc17886

Browse files
committed
add comment for new leader elector code
1 parent 0c35ede commit fc17886

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

pkg/manager/internal.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -351,6 +351,8 @@ func (cm *controllerManager) Start(ctx context.Context) (err error) {
351351
// Initialize the internal context.
352352
cm.internalCtx, cm.internalCancel = context.WithCancel(ctx)
353353

354+
// Leader elector must create before defer which contains engageStopProcedure function
355+
// https://github.com/kubernetes-sigs/controller-runtime/issues/2873
354356
var leaderElector *leaderelection.LeaderElector
355357
if cm.resourceLock != nil {
356358
leaderElector, err = cm.initLeaderElector()

0 commit comments

Comments
 (0)