Skip to content

Commit 1d82720

Browse files
authored
Merge pull request #5325 from BasJ93/docs-update-rfc2136
docs: update rfc2136
2 parents 5eaf814 + 7a2ba6d commit 1d82720

File tree

3 files changed

+31
-2
lines changed

3 files changed

+31
-2
lines changed

docs/flags.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@
133133
| `--exoscale-apisecret=""` | Provide your API Secret for the Exoscale provider |
134134
| `--rfc2136-host=` | When using the RFC2136 provider, specify the host of the DNS server (optionally specify multiple times when when using --rfc2136-load-balancing-strategy) |
135135
| `--rfc2136-port=0` | When using the RFC2136 provider, specify the port of the DNS server |
136-
| `--rfc2136-zone=RFC2136-ZONE` | When using the RFC2136 provider, specify zone entries of the DNS server to use |
136+
| `--rfc2136-zone=RFC2136-ZONE` | When using the RFC2136 provider, specify zone entry of the DNS server to use (can be specified multiple times) |
137137
| `--[no-]rfc2136-create-ptr` | When using the RFC2136 provider, enable PTR management |
138138
| `--[no-]rfc2136-insecure` | When using the RFC2136 provider, specify whether to attach TSIG or not (default: false, requires --rfc2136-tsig-keyname and rfc2136-tsig-secret) |
139139
| `--rfc2136-tsig-keyname=""` | When using the RFC2136 provider, specify the TSIG key to attached to DNS messages (required when --rfc2136-insecure=false) |

docs/tutorials/rfc2136.md

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -497,6 +497,35 @@ external-dns \
497497
--rfc2136-insecure
498498
```
499499

500+
### Helm
501+
502+
```yaml
503+
extraArgs:
504+
- --rfc2136-host="dns-host-1.yourdomain.com"
505+
- --rfc2136-port=53
506+
- --rfc2136-zone=example.com
507+
- --rfc2136-tsig-secret-alg=hmac-sha256
508+
- --rfc2136-tsig-axfr
509+
510+
env:
511+
- name: "EXTERNAL_DNS_RDC2136_TSIG_SECRET"
512+
valueFrom:
513+
secretKeyRef:
514+
name: rfc2136-keys
515+
key: rfc2136-tsig-secret
516+
- name: "EXTERNAL_DNS_RDC2136_TSIG_KEYNAME"
517+
valueFrom:
518+
secretKeyRef:
519+
name: rfc2136-keys
520+
key: rfc2136-tsig-keyname
521+
```
522+
523+
#### Secret creation
524+
525+
```shell
526+
kubectl create secret generic rfc2136-keys --from-literal=rfc2136-tsig-secret='xxx' --from-literal=rfc2136-tsig-keyname='k8s-external-dns-key' -n external-dns
527+
```
528+
500529
### Benefits
501530

502531
- Distributes the load of DNS updates across multiple data centers, preventing any single DC from becoming a bottleneck.

pkg/apis/externaldns/types.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -580,7 +580,7 @@ func App(cfg *Config) *kingpin.Application {
580580
// Flags related to RFC2136 provider
581581
app.Flag("rfc2136-host", "When using the RFC2136 provider, specify the host of the DNS server (optionally specify multiple times when when using --rfc2136-load-balancing-strategy)").Default(defaultConfig.RFC2136Host[0]).StringsVar(&cfg.RFC2136Host)
582582
app.Flag("rfc2136-port", "When using the RFC2136 provider, specify the port of the DNS server").Default(strconv.Itoa(defaultConfig.RFC2136Port)).IntVar(&cfg.RFC2136Port)
583-
app.Flag("rfc2136-zone", "When using the RFC2136 provider, specify zone entries of the DNS server to use").StringsVar(&cfg.RFC2136Zone)
583+
app.Flag("rfc2136-zone", "When using the RFC2136 provider, specify zone entry of the DNS server to use (can be specified multiple times)").StringsVar(&cfg.RFC2136Zone)
584584
app.Flag("rfc2136-create-ptr", "When using the RFC2136 provider, enable PTR management").Default(strconv.FormatBool(defaultConfig.RFC2136CreatePTR)).BoolVar(&cfg.RFC2136CreatePTR)
585585
app.Flag("rfc2136-insecure", "When using the RFC2136 provider, specify whether to attach TSIG or not (default: false, requires --rfc2136-tsig-keyname and rfc2136-tsig-secret)").Default(strconv.FormatBool(defaultConfig.RFC2136Insecure)).BoolVar(&cfg.RFC2136Insecure)
586586
app.Flag("rfc2136-tsig-keyname", "When using the RFC2136 provider, specify the TSIG key to attached to DNS messages (required when --rfc2136-insecure=false)").Default(defaultConfig.RFC2136TSIGKeyName).StringVar(&cfg.RFC2136TSIGKeyName)

0 commit comments

Comments
 (0)