Skip to content

Commit c016dc6

Browse files
authored
Merge pull request #5126 from mloiseleur/remove/designate
chore(openstack designate)!: remove in-tree provider
2 parents a4fac0a + 313e15a commit c016dc6

File tree

7 files changed

+2
-1346
lines changed

7 files changed

+2
-1346
lines changed

README.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ ExternalDNS allows you to keep selected zones (via `--domain-filter`) synchroniz
4949
- [CloudFlare](https://www.cloudflare.com/dns)
5050
- [DigitalOcean](https://www.digitalocean.com/products/networking)
5151
- [DNSimple](https://dnsimple.com/)
52-
- [OpenStack Designate](https://docs.openstack.org/designate/latest/)
5352
- [PowerDNS](https://www.powerdns.com/)
5453
- [CoreDNS](https://coredns.io/)
5554
- [Exoscale](https://www.exoscale.com/dns/)
@@ -137,7 +136,6 @@ The following table clarifies the current status of the providers according to t
137136
| CloudFlare | Beta | |
138137
| DigitalOcean | Alpha | |
139138
| DNSimple | Alpha | |
140-
| OpenStack Designate | Alpha | |
141139
| PowerDNS | Alpha | |
142140
| CoreDNS | Alpha | |
143141
| Exoscale | Alpha | |
@@ -204,7 +202,6 @@ The following tutorials are provided:
204202
- [NS Record Creation with CRD Source](docs/sources/ns-record.md)
205203
- [MX Record Creation with CRD Source](docs/sources/mx-record.md)
206204
- [TXT Record Creation with CRD Source](docs/sources/txt-record.md)
207-
- [OpenStack Designate](docs/tutorials/designate.md)
208205
- [Oracle Cloud Infrastructure (OCI) DNS](docs/tutorials/oracle.md)
209206
- [PowerDNS](docs/tutorials/pdns.md)
210207
- [RFC2136](docs/tutorials/rfc2136.md)

docs/flags.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
| `--[no-]traefik-disable-legacy` | Disable listeners on Resources under the traefik.containo.us API Group |
5050
| `--[no-]traefik-disable-new` | Disable listeners on Resources under the traefik.io API Group |
5151
| `--nat64-networks=NAT64-NETWORKS` | Adding an A record for each AAAA record in NAT64-enabled networks; specify multiple times for multiple possible nets (optional) |
52-
| `--provider=provider` | The DNS provider where the DNS records will be created (required, options: akamai, alibabacloud, aws, aws-sd, azure, azure-dns, azure-private-dns, civo, cloudflare, coredns, designate, digitalocean, dnsimple, exoscale, gandi, godaddy, google, ibmcloud, inmemory, linode, ns1, oci, ovh, pdns, pihole, plural, rfc2136, scaleway, skydns, tencentcloud, transip, ultradns, webhook) |
52+
| `--provider=provider` | The DNS provider where the DNS records will be created (required, options: akamai, alibabacloud, aws, aws-sd, azure, azure-dns, azure-private-dns, civo, cloudflare, coredns, digitalocean, dnsimple, exoscale, gandi, godaddy, google, ibmcloud, inmemory, linode, ns1, oci, ovh, pdns, pihole, plural, rfc2136, scaleway, skydns, tencentcloud, transip, ultradns, webhook) |
5353
| `--provider-cache-time=0s` | The time to cache the DNS provider record list requests. |
5454
| `--domain-filter=` | Limit possible target zones by a domain suffix; specify multiple times for multiple domains (optional) |
5555
| `--exclude-domains=` | Exclude subdomains (optional) |

docs/tutorials/designate.md

Lines changed: 0 additions & 258 deletions
This file was deleted.

main.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,6 @@ import (
5050
"sigs.k8s.io/external-dns/provider/civo"
5151
"sigs.k8s.io/external-dns/provider/cloudflare"
5252
"sigs.k8s.io/external-dns/provider/coredns"
53-
"sigs.k8s.io/external-dns/provider/designate"
5453
"sigs.k8s.io/external-dns/provider/digitalocean"
5554
"sigs.k8s.io/external-dns/provider/dnsimple"
5655
"sigs.k8s.io/external-dns/provider/exoscale"
@@ -287,8 +286,6 @@ func main() {
287286
)
288287
case "inmemory":
289288
p, err = inmemory.NewInMemoryProvider(inmemory.InMemoryInitZones(cfg.InMemoryZones), inmemory.InMemoryWithDomain(domainFilter), inmemory.InMemoryWithLogging()), nil
290-
case "designate":
291-
p, err = designate.NewDesignateProvider(domainFilter, cfg.DryRun)
292289
case "pdns":
293290
p, err = pdns.NewPDNSProvider(
294291
ctx,

pkg/apis/externaldns/types.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -484,7 +484,7 @@ func App(cfg *Config) *kingpin.Application {
484484
app.Flag("nat64-networks", "Adding an A record for each AAAA record in NAT64-enabled networks; specify multiple times for multiple possible nets (optional)").StringsVar(&cfg.NAT64Networks)
485485

486486
// Flags related to providers
487-
providers := []string{"akamai", "alibabacloud", "aws", "aws-sd", "azure", "azure-dns", "azure-private-dns", "civo", "cloudflare", "coredns", "designate", "digitalocean", "dnsimple", "exoscale", "gandi", "godaddy", "google", "ibmcloud", "inmemory", "linode", "ns1", "oci", "ovh", "pdns", "pihole", "plural", "rfc2136", "scaleway", "skydns", "tencentcloud", "transip", "ultradns", "webhook"}
487+
providers := []string{"akamai", "alibabacloud", "aws", "aws-sd", "azure", "azure-dns", "azure-private-dns", "civo", "cloudflare", "coredns", "digitalocean", "dnsimple", "exoscale", "gandi", "godaddy", "google", "ibmcloud", "inmemory", "linode", "ns1", "oci", "ovh", "pdns", "pihole", "plural", "rfc2136", "scaleway", "skydns", "tencentcloud", "transip", "ultradns", "webhook"}
488488
app.Flag("provider", "The DNS provider where the DNS records will be created (required, options: "+strings.Join(providers, ", ")+")").Required().PlaceHolder("provider").EnumVar(&cfg.Provider, providers...)
489489
app.Flag("provider-cache-time", "The time to cache the DNS provider record list requests.").Default(defaultConfig.ProviderCacheTime.String()).DurationVar(&cfg.ProviderCacheTime)
490490
app.Flag("domain-filter", "Limit possible target zones by a domain suffix; specify multiple times for multiple domains (optional)").Default("").StringsVar(&cfg.DomainFilter)

0 commit comments

Comments
 (0)