Skip to content

Commit 74a9dfc

Browse files
authored
Use EXTRA_TAG for Helm App version if it is semantic versioning (#5108)
Signed-off-by: Yuki Iwai <[email protected]>
1 parent 37aba5c commit 74a9dfc

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

hack/push-chart.sh

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,14 +36,13 @@ readonly semver_regex='^v([0-9]+)(\.[0-9]+){1,2}$'
3636

3737
image_repository=${IMAGE_REPO}
3838
app_version=${GIT_TAG}
39-
# Strip leading v from version
40-
chart_version="${app_version/#v/}"
4139
if [[ ${EXTRA_TAG} =~ ${semver_regex} ]]
4240
then
4341
image_repository=${k8s_registry}/kueue
44-
# Strip leading v from version
45-
chart_version=${EXTRA_TAG/#v/}
42+
app_version=${EXTRA_TAG}
4643
fi
44+
# Strip leading v from version
45+
chart_version="${app_version/#v/}"
4746

4847
default_image_repo=$(${YQ} ".controllerManager.manager.image.repository" charts/kueue/values.yaml)
4948
readonly default_image_repo

0 commit comments

Comments
 (0)