Skip to content

use given rtol/atol in SessionComparator listwidget #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gdementen opened this issue Nov 7, 2019 · 0 comments
Open

use given rtol/atol in SessionComparator listwidget #201

gdementen opened this issue Nov 7, 2019 · 0 comments

Comments

@gdementen
Copy link
Collaborator

Currently the given rtol/atol is used in the widget on the right but has no effect on the red coloring of the array names on the left which is confusing and annoying.

If we fix that, we will want to also update the list when we change the tolerance, which will be slow.

While it is super handy for "smallish" sessions (you immediately see which arrays have differences), computing that list color systematically may not be the best idea. Unsure how to keep the handy side but avoid a sluggish interface when comparing largish sessions. @alixdamman Do you have an idea to reconcile the two?

Also, if we fix this problem, we might want to move the tolerance & "show differences only" widgets somewhere else to make it more obvious they have an effect for all arrays comparisons, not just the current one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant