Skip to content

Commit d37d273

Browse files
cclausslegendecas
authored andcommitted
DRAFT: Test on GitHub Actions windows-2025 image
* actions/runner-images#11228
1 parent 94448fc commit d37d273

File tree

2 files changed

+13
-8
lines changed

2 files changed

+13
-8
lines changed

.github/workflows/tests.yml

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -92,14 +92,17 @@ jobs:
9292
needs: [lint-python]
9393
strategy:
9494
fail-fast: false
95-
max-parallel: 15
95+
max-parallel: 11
9696
matrix:
9797
os: [macos-latest, ubuntu-latest, windows-latest]
98-
python: ["3.8", "3.10", "3.12"]
98+
python: ["3.9", "3.11", "3.13"]
9999
node: [18.x, 20.x, 22.x]
100-
include: # `npm test` runs Windows find-visualstudio tests on an Intel Mac!!!
100+
include:
101101
- os: macos-13
102-
python: "3.12"
102+
python: "3.13"
103+
node: 22.x
104+
- os: windows-2025
105+
python: "3.13"
103106
node: 22.x
104107
name: ${{ matrix.os }} - ${{ matrix.python }} - ${{ matrix.node }}
105108
runs-on: ${{ matrix.os }}
@@ -129,14 +132,14 @@ jobs:
129132
- name: Run Python Tests
130133
run: python -m pytest
131134
- name: Run Tests (macOS or Linux)
132-
if: "!startsWith(matrix.os, 'windows')"
135+
if: runner.os != 'Windows'
133136
shell: bash
134137
run: npm test --python="${pythonLocation}/python"
135138
env:
136-
FULL_TEST: ${{ (matrix.node == '22.x' && matrix.python == '3.12') && '1' || '0' }}
139+
FULL_TEST: ${{ (matrix.node == '22.x' && matrix.python == '3.13') && '1' || '0' }}
137140
- name: Run Tests (Windows)
138-
if: startsWith(matrix.os, 'windows')
141+
if: runner.os == 'Windows'
139142
shell: bash # Building wasm on Windows requires using make generator, it only works in bash
140143
run: npm run test --python="${pythonLocation}\\python.exe"
141144
env:
142-
FULL_TEST: ${{ (matrix.node == '22.x' && matrix.python == '3.12') && '1' || '0' }}
145+
FULL_TEST: ${{ (matrix.node == '22.x' && matrix.python == '3.13') && '1' || '0' }}

.github/workflows/visual-studio.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ jobs:
2121
msvs-verison: 2019
2222
- os: windows-2022
2323
msvs-version: 2022
24+
- os: windows-2025
25+
msvs-version: 2022 # Fix this when Visual Studio 2025 is released
2426
runs-on: ${{ matrix.os }}
2527
steps:
2628
- name: Checkout Repository

0 commit comments

Comments
 (0)