chore: add tests for peer-discovery interface

Author: vasco-santos

package.json

@@ -30,7 +30,8 @@
   "devDependencies": {
     "aegir": "^21.2.0",
     "chai": "^4.2.0",
-    "dirty-chai": "^2.0.1"
+    "dirty-chai": "^2.0.1",
+    "libp2p-interfaces": "libp2p/js-interfaces#v0.3.x"
   },
   "dependencies": {
     "debug": "^4.1.1",

src/index.js

@@ -49,6 +49,10 @@ class Bootstrap extends EventEmitter {
    * Emit each address in the list as a PeerInfo.
    */
   _discoverBootstrapPeers () {
+    if (!this._timer) {
+      return
+    }
+
     this._list.forEach((candidate) => {
       if (!mafmt.P2P.matches(candidate)) {
         return log.error('Invalid multiaddr')
@@ -73,10 +77,8 @@ class Bootstrap extends EventEmitter {
    * Stop emitting events.
    */
   stop () {
-    if (this._timer) {
-      clearInterval(this._timer)
-      this._timer = null
-    }
+    clearInterval(this._timer)
+    this._timer = null
   }
 }
 

test/compliance.spec.js

@@ -0,0 +1,21 @@
+'use strict'
+
+/* eslint-env mocha */
+
+const tests = require('libp2p-interfaces/src/peer-discovery/tests')
+
+const Bootstrap = require('../src')
+const peerList = require('./default-peers')
+
+describe('compliance tests', () => {
+  tests({
+    setup () {
+      const bootstrap = new Bootstrap({
+        list: peerList,
+        interval: 2000
+      })
+
+      return bootstrap
+    }
+  })
+})