feat: migrate to quick-protobuf

Instead of relying on `protoc` and buildscripts, we generate the bindings using `pb-rs` and version them within our codebase. This makes for a better IDE integration, a faster build and an easier use of `rust-libp2p` because we don't force the `protoc` dependency onto them.

Resolves #3024.

Pull-Request: #3312.

Author: kckeiks

.github/workflows/ci.yml

@@ -293,3 +293,30 @@ jobs:
             echo "PR title is too long (greater than 72 characters)"
             exit 1
           fi
+
+  check-proto-files:
+    name: Check for changes in proto files
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+
+      - uses: Swatinem/rust-cache@359a70e43a0bb8a13953b04a90f76428b4959bb6 # v2.2.0
+
+      - run: cargo install --version 0.10.0 pb-rs --locked
+
+      - name: Glob match
+        uses: tj-actions/glob@v16
+        id: glob
+        with:
+          files: |
+            **/generated/*.proto
+
+      - name: Generate proto files
+        run: pb-rs --dont_use_cow ${{ steps.glob.outputs.paths }}
+
+      - name: Ensure generated files are unmodified # https://stackoverflow.com/a/5737794
+        run: |
+            git_status=$(git status --porcelain)
+
+            echo $git_status
+            test -z "$git_status"

Cargo.lock

@@ -146,7 +146,7 @@ members = [
     "misc/multistream-select",
     "misc/rw-stream-sink",
     "misc/keygen",
-    "misc/prost-codec",
+    "misc/quick-protobuf-codec",
     "misc/quickcheck-ext",
     "muxers/mplex",
     "muxers/yamux",

Cargo.toml

@@ -2,7 +2,9 @@
 
 - Move `ConnectionId` to `libp2p-swarm`. See [PR 3221].
 - Move `PendingPoint` to `libp2p-swarm` and make it crate-private. See [PR 3221].
+- Migrate from `prost` to `quick-protobuf`. This removes `protoc` dependency. See [PR 3312].
 
+[PR 3312]: https://github.com/libp2p/rust-libp2p/pull/3312
 [PR 3221]: https://github.com/libp2p/rust-libp2p/pull/3221
 
 # 0.38.0

core/CHANGELOG.md

@@ -27,7 +27,7 @@ multistream-select = { version = "0.12.1", path = "../misc/multistream-select" }
 p256 = { version = "0.12.0", default-features = false, features = ["ecdsa", "std"], optional = true }
 parking_lot = "0.12.0"
 pin-project = "1.0.0"
-prost = "0.11"
+quick-protobuf = "0.8"
 once_cell = "1.17.1"
 rand = "0.8"
 rw-stream-sink = { version = "0.3.0", path = "../misc/rw-stream-sink" }
@@ -54,9 +54,6 @@ quickcheck = { package = "quickcheck-ext", path = "../misc/quickcheck-ext" }
 rmp-serde = "1.0"
 serde_json = "1.0"
 
-[build-dependencies]
-prost-build = "0.11"
-
 [features]
 secp256k1 = [ "libsecp256k1" ]
 ecdsa = [ "p256" ]