Skip to content

Commit d639b91

Browse files
authored
[NFC][mlir][gpu] Fully-qualify all namespaces in the GPU compilation interfaces (#94908)
Fully qualify all namespaces appearing in `GPUTargetAttrInterface` and `OffloadingLLVMTranslationAttrInterface`. If they're not fully qualified then out-of-tree dialects might encounter name resolution errors.
1 parent 014446c commit d639b91

File tree

1 file changed

+14
-12
lines changed

1 file changed

+14
-12
lines changed

mlir/include/mlir/Dialect/GPU/IR/CompilationAttrInterfaces.td

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -37,17 +37,18 @@ def GPUTargetAttrInterface : AttrInterface<"TargetAttrInterface"> {
3737
is meant to be used for passing additional options that are not in the
3838
attribute.
3939
}],
40-
"std::optional<SmallVector<char, 0>>", "serializeToObject",
41-
(ins "Operation*":$module, "const gpu::TargetOptions&":$options)>,
40+
"std::optional<::mlir::SmallVector<char, 0>>", "serializeToObject",
41+
(ins "::mlir::Operation*":$module,
42+
"const ::mlir::gpu::TargetOptions&":$options)>,
4243
InterfaceMethod<[{
4344
Creates a GPU object attribute from a binary string.
4445

4546
The `object` parameter is a binary string. The `options` parameter is
4647
meant to be used for passing additional options that are not in the
4748
attribute.
48-
}], "Attribute", "createObject",
49-
(ins "const SmallVector<char, 0>&":$object,
50-
"const gpu::TargetOptions&":$options)>
49+
}], "::mlir::Attribute", "createObject",
50+
(ins "const ::llvm::SmallVector<char, 0>&":$object,
51+
"const ::mlir::gpu::TargetOptions&":$options)>
5152
];
5253
}
5354

@@ -112,9 +113,10 @@ def OffloadingLLVMTranslationAttrInterface :
112113
The first argument has to be a GPU binary operation.
113114
If the function fails at any point, it must return `failure`.
114115
}],
115-
"LogicalResult", "embedBinary",
116-
(ins "Operation*":$binaryOp, "llvm::IRBuilderBase&":$hostBuilder,
117-
"LLVM::ModuleTranslation&":$hostModuleTranslation)
116+
"::mlir::LogicalResult", "embedBinary",
117+
(ins "::mlir::Operation*":$binaryOp,
118+
"::llvm::IRBuilderBase&":$hostBuilder,
119+
"::mlir::LLVM::ModuleTranslation&":$hostModuleTranslation)
118120
>,
119121
InterfaceMethod<[{
120122
Translates a `gpu.launch_func` op into a sequence of LLVM IR
@@ -128,10 +130,10 @@ def OffloadingLLVMTranslationAttrInterface :
128130
respectively. If the function fails at any point, it must return
129131
`failure`.
130132
}],
131-
"LogicalResult", "launchKernel",
132-
(ins "Operation*":$launchFunc, "Operation*":$binaryOp,
133-
"llvm::IRBuilderBase&":$hostBuilder,
134-
"LLVM::ModuleTranslation&":$hostModuleTranslation)
133+
"::mlir::LogicalResult", "launchKernel",
134+
(ins "::mlir::Operation*":$launchFunc, "::mlir::Operation*":$binaryOp,
135+
"::llvm::IRBuilderBase&":$hostBuilder,
136+
"::mlir::LLVM::ModuleTranslation&":$hostModuleTranslation)
135137
>
136138
];
137139
}

0 commit comments

Comments
 (0)