Skip to content

[Issue] Fix: Allow to fetch tax class ID for NOT LOGGED IN customer group #39850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
5 tasks
m2-assistant bot opened this issue Apr 22, 2025 · 2 comments · May be fixed by #39822
Open
5 tasks

[Issue] Fix: Allow to fetch tax class ID for NOT LOGGED IN customer group #39850

m2-assistant bot opened this issue Apr 22, 2025 · 2 comments · May be fixed by #39822
Labels
Issue: needs update Additional information is require, waiting for response Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Reported on 2.4.x Indicates original Magento version for the Issue report.

Comments

@m2-assistant
Copy link

m2-assistant bot commented Apr 22, 2025

This issue is automatically created based on existing pull request: #39822: Fix: Allow to fetch tax class ID for NOT LOGGED IN customer group

Description (*)

When using \Magento\Catalog\Helper\Data::getTaxPrice to fetch price, tax details are miscalculated for context with guest users.

Here the group id 0 was interpreted as NULL while it shouldn't.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot linked a pull request Apr 22, 2025 that will close this issue
Open
6 tasks
@github-project-automation github-project-automation bot moved this to Ready for Confirmation in Issue Confirmation and Triage Board Apr 22, 2025
@engcom-Bravo engcom-Bravo added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Apr 22, 2025
@ct-prd-projects-boards-automation ct-prd-projects-boards-automation bot moved this to Ready for Development in High Priority Backlog Apr 22, 2025
@engcom-Bravo engcom-Bravo added the Reported on 2.4.x Indicates original Magento version for the Issue report. label Apr 22, 2025
@engcom-November
Copy link
Contributor

Hello @thomas-kl1 ,

Thank for your report and collaboration.

However, we’re currently unable to identify the exact issue. Could you please provide the following details to help us review it more effectively:

  • A clear description of the issue
  • Steps to reproduce it
  • Expected vs. actual results
  • A screencast or screenshots, if possible

This information will greatly assist us in understanding and addressing the issue.

Hence marking this issue as "Needs Update"

Thank you!

@engcom-November engcom-November added the Issue: needs update Additional information is require, waiting for response label May 22, 2025
@thomas-kl1
Copy link
Member

When Magento render the product price on the frontend, it completely ignore the tax class ID for the customer group "Not Logged In", if the visitor is a guest. The tax class is then resolved from the product as default.
The fix is really easy as seen in the suggested change, it's because the comparison implicitly cast the customer group ID "0" as null. That's why the strict comparison is necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue: needs update Additional information is require, waiting for response Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Reported on 2.4.x Indicates original Magento version for the Issue report.
Projects
High Priority Backlog
Status: Ready for Development
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Allow to fetch tax class ID for NOT LOGGED IN customer group thomas-kl1/magento2
3 participants
@thomas-kl1 @engcom-Bravo @engcom-November