Skip to content

Upgrade to matrix-appservice-bridge 5.0.0 #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 29, 2022
Merged

Upgrade to matrix-appservice-bridge 5.0.0 #690

merged 7 commits into from
Jul 29, 2022

Conversation

Half-Shot
Copy link
Contributor

@Half-Shot Half-Shot commented Jul 26, 2022 •
edited
Loading

This includes a minimum Node version bump to Node.JS 16.0. This PR includes a handful of typing cleanups from where we were overusing the ! operator, or ignoring obviously-wrong types.

@Half-Shot Half-Shot requested a review from a team July 26, 2022 10:12
AndrewFerr
AndrewFerr reviewed Jul 26, 2022
View reviewed changes
Copy link
Member

@AndrewFerr AndrewFerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just skimmed through the typing cleanups, but they look fine overall. Lint warnings are also down a bit (-13), which is nice.

tadzik
tadzik suggested changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@tadzik tadzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs fixes to the Dockerfile, as it currently fails to start due to:

Error: Cannot find module '@matrix-org/matrix-sdk-crypto-nodejs-linux-x64-gnu'

Dropping --ignore-scripts fixes it

@Half-Shot Half-Shot requested a review from tadzik July 29, 2022 13:28
@Half-Shot Half-Shot force-pushed the hs/as-bridge-5.0.0 branch from fa3e7c7 to 89fb41e Compare July 29, 2022 13:30
@Half-Shot Half-Shot mentioned this pull request Jul 29, 2022
Closed
@Half-Shot Half-Shot merged commit 2be3824 into develop Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewFerr AndrewFerr AndrewFerr left review comments

@tadzik tadzik tadzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Half-Shot @tadzik @AndrewFerr