Skip to content

Commit deedec0

Browse files
bp3tk0vIngo Molnar
authored and
Ingo Molnar
committed
x86/cpu: Fix the AMD Fam 17h, Fam 19h, Zen2 and Zen4 MSR enumerations
The comments introduced in <asm/msr-index.h> in the merge conflict fixup in: 8f4156d ("Merge branch 'x86/urgent' into perf/core, to resolve conflict") ... aren't right: AMD naming schemes are more complex than implied, family 0x17 is Zen1 and 2, family 0x19 is spread around Zen 3 and 4. So there's indeed four separate MSR namespaces for: MSR_F17H_ MSR_F19H_ MSR_ZEN2_ MSR_ZEN4_ ... and the namespaces cannot be merged. Fix it up. No change in functionality. Signed-off-by: Borislav Petkov (AMD) <[email protected]> Signed-off-by: Ingo Molnar <[email protected]> Cc: Peter Zijlstra <[email protected]> Link: https://lore.kernel.org/r/[email protected]
1 parent f06cc66 commit deedec0

File tree

1 file changed

+11
-9
lines changed

1 file changed

+11
-9
lines changed

arch/x86/include/asm/msr-index.h

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -637,18 +637,20 @@
637637
/* AMD Last Branch Record MSRs */
638638
#define MSR_AMD64_LBR_SELECT 0xc000010e
639639

640-
/* Fam 19h (Zen 4) MSRs */
641-
#define MSR_F19H_UMC_PERF_CTL 0xc0010800
642-
#define MSR_F19H_UMC_PERF_CTR 0xc0010801
643-
644-
#define MSR_ZEN4_BP_CFG 0xc001102e
640+
/* Zen4 */
641+
#define MSR_ZEN4_BP_CFG 0xc001102e
645642
#define MSR_ZEN4_BP_CFG_SHARED_BTB_FIX_BIT 5
646643

647-
/* Fam 17h (Zen 2) MSRs */
648-
#define MSR_F17H_IRPERF 0xc00000e9
644+
/* Fam 19h MSRs */
645+
#define MSR_F19H_UMC_PERF_CTL 0xc0010800
646+
#define MSR_F19H_UMC_PERF_CTR 0xc0010801
649647

650-
#define MSR_ZEN2_SPECTRAL_CHICKEN 0xc00110e3
651-
#define MSR_ZEN2_SPECTRAL_CHICKEN_BIT BIT_ULL(1)
648+
/* Zen 2 */
649+
#define MSR_ZEN2_SPECTRAL_CHICKEN 0xc00110e3
650+
#define MSR_ZEN2_SPECTRAL_CHICKEN_BIT BIT_ULL(1)
651+
652+
/* Fam 17h MSRs */
653+
#define MSR_F17H_IRPERF 0xc00000e9
652654

653655
/* Fam 16h MSRs */
654656
#define MSR_F16H_L2I_PERF_CTL 0xc0010230

0 commit comments

Comments
 (0)