Skip to content

Arduino Library...? #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gicking opened this issue Nov 20, 2021 · 3 comments
Closed

Arduino Library...? #18

gicking opened this issue Nov 20, 2021 · 3 comments

Comments

@gicking
Copy link

gicking commented Nov 20, 2021

hi Max,

I really like your Modbus library, as it just does the jobs, no frills... :-) To increase visibility, have you considered making it available as an Arduino library?

PS: my STM8 port of your library can be found here. Thanks again!

@mbs38
Copy link
Owner

mbs38 commented Dec 20, 2021

Hi Georg,

thx for your message. Highly appreciated. I have been asked several times to bring the lib to Arduino but I never really use Arduino so this is extremely low on my list. So low in fact that I will probably never do it. If someone else did it I would be more than happy.

Thanks for pointing me to your STM8 port. Very nicely done. I will probably use it. I've been thinking about porting to STM for a while :-)

Best,
Max

@gicking
Copy link
Author

gicking commented Dec 22, 2021

Hi Max,

:-) On 2nd thought porting yaMBSiavr to Arduino would probably be pretty awkward, because the Arduino framework does not support to attach functions to Uart interrupts out of the box. While lib NeoHWSerial adds this for the 8-bit AVR boards, this is not possible for the newer 32-bit ARM, e.g. Due (see this discussion), let alone the plethora of "Arduino-like" boards.

I believe that your implementation is correct, and that handling Modbus via polling is not the way to go. However, I did find several Arduino libraries which seem to do a pretty good job if the protocol handler is called every 1ms or so. So please ignore my proposal, and let's keep your lib as it is, i.e. for bare-metal programmers.

As for my STM8 port, please feel free to use it! How about you add a "port" folder to your repo for different kinds of controllers?

In any case thanks again for your effort! Well done...

Regards, Georg

@mbs38
Copy link
Owner

mbs38 commented Dec 31, 2023

Hi,
sorry for the late response. Thx for pointing me to your STM8 port! :-)

Best regards,
Max

@mbs38 mbs38 closed this as completed Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants