temp

Author: sheetalkamat

src/compiler/resolutionCache.ts

@@ -796,6 +796,9 @@ export function createResolutionCache(
     }
 
     function getValidResolution<T extends ResolutionWithFailedLookupLocations>(resolution: T | undefined) {
+        // TODO: (sheetal) this isnt correct because after the new resolution is calculated and its still unresolved with globalCachePass:
+        // it will mark new resolution as invalidated as well
+        //  (unresolvedResolutionsWithGlobalCachePassAreInvalidated && resolution.globalCacheResolution && isUnresolvedOrResolvedToJs(resolution as ResolvedModuleWithFailedLookupLocations));
         return isInvalidatedResolution(resolution) ? undefined : resolution;
     }
 
@@ -1395,6 +1398,8 @@ export function createResolutionCache(
 
         // filePath is for the projectReference and the containing file is from this project reference, invalidate the resolution
         resolvedProjectReference.commandLine.fileNames.forEach(f => removeResolutionsOfFile(resolutionHost.toPath(f)));
+
+        // TODO: (sheetal) this is not correct as we would want to instead update to re-evaluate redirected-references
     }
 
     function removeResolutionsOfFile(filePath: Path, syncDirWatcherRemove?: boolean) {