Add NPM Publish Dry Run Job + Refactor publish.yml

Author: Saadnajmi

.ado/Brewfile

@@ -1,2 +1,4 @@
 brew "watchman"
 brew "xcbeautify"
+# macOS 12 doesn't have `realpath` but macOS 13 does. Remove this line when Azure Pipelines supports macOS 13 images.
+brew "coreutils"

.ado/apple-pr.yml

@@ -223,3 +223,52 @@ jobs:
       - template: templates/react-native-macos-init.yml
         parameters:
           configuration: $(configuration)
+
+  - job: NPMPublishDryRun
+    displayName: NPM Publish Dry Run
+    pool:
+      vmImage: $(VmImageApple)
+    timeoutInMinutes: 60 # how long to run the job before automatically cancelling
+    cancelTimeoutInMinutes: 5 # how much time to give 'run always even if cancelled tasks' before killing them
+    steps:
+      - checkout: self # self represents the repo where the initial Pipelines YAML file was found
+        clean: true # whether to fetch clean each time
+        # fetchDepth: 2 # the depth of commits to ask Git to fetch
+        lfs: false # whether to download Git-LFS files
+        submodules: recursive # set to 'true' for a single level of submodules or 'recursive' to get submodules of submodules
+        persistCredentials: true # set to 'true' to leave the OAuth token in the Git config after the initial fetch
+
+      - template: templates/apple-tools-setup.yml
+
+      - template: templates/apple-install-dependencies.yml
+
+      - task: CmdLine@2
+        displayName: Set next version if release branch
+        inputs:
+          script: |
+            VERSION=$(node .ado/get-next-semver-version.js)
+            echo "Set Version to: $VERSION"
+        condition: and(succeeded(), ne(variables['Build.SourceBranchName'], 'main'))
+
+
+      - task: CmdLine@2
+        displayName: Prepare package for release
+        inputs:
+          script: |
+            if [[ -z "$VERSION" ]]; then
+              VERSION=$(grep '"version"' package.json | cut -d '"' -f 4 | head -1)
+              echo "Using the version from the package.json: $VERSION"
+            fi
+            node ./scripts/prepare-package-for-release.js -v "$VERSION" -l false --dry-run true
+
+      - task: CmdLine@2
+        displayName: NPM Publish Dry Run
+        inputs:
+          script: |
+            node ./scripts/publish-npm.js --dry-run
+
+      - task: CmdLine@2
+        displayName: Print tarball output
+        inputs:
+          script: |
+            npm publish --dry-run

.ado/bumpFileVersions.js

@@ -19,7 +19,7 @@ function gatherVersionInfo() {
     return {pkgJson, releaseVersion, branchVersionSuffix};
 }
 
-function updateVersionsInFiles(patchVersionPrefix) {
+function getNextVersion(patchVersionPrefix) {
 
     let {pkgJson, releaseVersion, branchVersionSuffix} = gatherVersionInfo();
 
@@ -42,34 +42,9 @@ function updateVersionsInFiles(patchVersionPrefix) {
     }
 
     pkgJson.version = releaseVersion;
-    console.log(`Bumping files to version ${releaseVersion}`);
-    execSync(`node ./scripts/set-rn-version.js --rnmpublish --to-version ${releaseVersion}`, {stdio: 'inherit', env: process.env});
 
     return {releaseVersion, branchVersionSuffix};
 }
 
-const workspaceJsonPath = path.resolve(require('os').tmpdir(), 'rnpkg.json');
-
-function removeWorkspaceConfig() {
-  let {pkgJson} = gatherVersionInfo();
-  fs.writeFileSync(workspaceJsonPath, JSON.stringify(pkgJson, null, 2));
-  delete pkgJson.private;
-  delete pkgJson.workspaces;
-  fs.writeFileSync(pkgJsonPath, JSON.stringify(pkgJson, null, 2));
-  console.log(`Removing workspace config from package.json to prepare to publish.`);
-}
-
-function restoreWorkspaceConfig() {
-  let pkgJson = JSON.parse(fs.readFileSync(workspaceJsonPath, "utf8"));
-  fs.writeFileSync(pkgJsonPath, JSON.stringify(pkgJson, null, 2));
-  console.log(`Restoring workspace config from package.json`);
-}
-
-module.exports = {
-    gatherVersionInfo,
-    publishBranchName,
-    pkgJsonPath,
-    removeWorkspaceConfig,
-    restoreWorkspaceConfig,
-    updateVersionsInFiles
-}
+const nextVersion = getNextVersion().releaseVersion;
+console.log(nextVersion);

.ado/versionUtils.js renamed to .ado/get-next-semver-version.js

@@ -0,0 +1,19 @@
+// @ts-check
+const fs = require("fs");
+const path = require("path");
+const semver = require('semver');
+const {execSync} = require('child_process');
+
+const pkgJsonPath = path.resolve(__dirname, "../package.json");
+let publishBranchName = '';
+try {
+  publishBranchName = process.env.BUILD_SOURCEBRANCH.match(/refs\/heads\/(.*)/)[1];
+} catch (error) {}
+
+if (publishBranchName === 'main') {
+  console.log('nightly');
+} else if (publishBranchName.endsWith('-stable')) {
+  console.log('release');
+} else {
+  process.exit(1);
+}

.ado/get-release-type.js

@@ -10,6 +10,7 @@ trigger:
     include:
       - main
       - 0.68-stable
+      - 0.71-stable
   paths:
     exclude:
       - package.json
@@ -43,79 +44,62 @@ jobs:
         submodules: recursive # set to 'true' for a single level of submodules or 'recursive' to get submodules of submodules
         persistCredentials: true # set to 'true' to leave the OAuth token in the Git config after the initial fetch
 
-      - script: exit 1
-        displayName: Validate variables
-        condition: eq(variables.latestStableBranch, '')
-
-      - bash: echo "##vso[task.setvariable variable=npmDistTag]latest"
-        displayName: Set dist-tag to latest
-        condition: eq(variables['Build.SourceBranchName'], variables.latestStableBranch)
-
-      - bash: echo "##vso[task.setvariable variable=npmDistTag]canary"
-        displayName: Set dist-tag to canary
-        condition: eq(variables['Build.SourceBranchName'], 'main')
+      - template: templates/apple-tools-setup.yml
 
-      - bash: echo "##vso[task.setvariable variable=npmDistTag]v${{variables['Build.SourceBranchName']}}"
-        displayName: Set dist-tag to v0.x-stable
-        condition: and(ne(variables['Build.SourceBranchName'], 'main'), ne(variables['Build.SourceBranchName'], variables.latestStableBranch))
+      - template: templates/apple-install-dependencies.yml
 
-      - template: templates/apple-tools-setup.yml
+      - template: templates/apple-release-setup.yml
 
       - task: CmdLine@2
-        displayName: yarn install
+        displayName: Set next version if release branch
         inputs:
-          script: yarn install --frozen-lockfile
+          script: |
+            VERSION=$(node .ado/get-next-semver-version.js)
+            echo "Set version to: $VERSION"
+        condition: and(succeeded(), ne(variables['Build.SourceBranchName'], 'main'))
 
       - task: CmdLine@2
-        displayName: Bump stable package version
+        displayName: Set release type
         inputs:
-          script: node .ado/bumpFileVersions.js
-        condition: and(succeeded(), ne(variables['Build.SourceBranchName'], 'main'))
-
+          script: |
+            RELEASE_TYPE=$(node .ado/get-next-release-type.js)
+            echo "Set release type to: $RELEASE_TYPE"
+  
       - task: CmdLine@2
-        displayName: Set canary package version
+        displayName: Set latest tag if latest stable branch
         inputs:
-          script: node scripts/set-rn-version.js --nightly --autogenerateVersionNumber
-        condition: and(succeeded(), eq(variables['Build.SourceBranchName'], 'main'))
+          script: |
+            LATEST=true
+            echo "Set latest to: $LATEST"
+        condition: eq(variables['Build.SourceBranchName'], $(latest_stable_branch))
 
-      # Publish will fail if package.json is marked as private
       - task: CmdLine@2
-        displayName: Remove workspace config from package.json
+        displayName: Prepare package for release
         inputs:
-          script: node .ado/removeWorkspaceConfig.js
+          script: |
+            if [[ -z "$VERSION" ]]; then
+              VERSION=$(grep '"version"' package.json | cut -d '"' -f 4 | head -1)
+              echo "Using the version from the package.json: $VERSION"
+            fi
+            node ./scripts/prepare-package-for-release.js -v "$VERSION" -l $LATEST
 
       - task: AzureArtifacts.manifest-generator-task.manifest-generator-task.ManifestGeneratorTask@0
         displayName: 📒 Generate Manifest
         inputs:
           BuildDropPath: $(System.DefaultWorkingDirectory)
 
+      - task: CmdLine@2
+        displayName: NPM Publish
+        inputs:
+          script: |
+            node ./scripts/publish-npm.js --$RELEASE_TYPE
+
       - task: PublishPipelineArtifact@1
         displayName: 📒 Publish Manifest
         inputs:
           artifactName: SBom-RNGithubNpmJSPublish-$(System.JobAttempt)
           targetPath: $(System.DefaultWorkingDirectory)/_manifest
 
-      - script: npm publish --tag $(npmDistTag) --registry https://registry.npmjs.org/ --//registry.npmjs.org/:_authToken=$(npmAuthToken)
-        displayName: Publish react-native-macos to npmjs.org
-
-      # Put the private flag back so that the removal does not get committed by the tag release step
-      - task: CmdLine@2
-        displayName: Restore package.json workspace config
-        inputs:
-          script: node .ado/restoreWorkspaceConfig.js
-
-      - task: CmdLine@2
-        displayName: 'Tag published release'
-        inputs:
-          script: node .ado/gitTagRelease.js
-        env:
-          BUILD_STAGINGDIRECTORY: $(Build.StagingDirectory)
-          BUILD_SOURCEBRANCH: $(Build.SourceBranch)
-          SYSTEM_ACCESSTOKEN: $(System.AccessToken)
-          githubApiToken: $(githubAuthToken)
-        condition: and(succeeded(), ne(variables['Build.SourceBranchName'], 'main'))
-
-
   - job: RNMacOSInitNpmJSPublish
     displayName: react-native-macos-init Publish to npmjs.org
     pool: cxeiss-ubuntu-20-04-large
@@ -132,17 +116,14 @@ jobs:
         submodules: recursive # set to 'true' for a single level of submodules or 'recursive' to get submodules of submodules
         persistCredentials: true # set to 'true' to leave the OAuth token in the Git config after the initial fetch
 
-      - template: templates/configure-git.yml
+      - template: templates/apple-tools-setup.yml
 
-      - task: CmdLine@2
-        displayName: yarn install
-        inputs:
-          script: |
-            cd packages/react-native-macos-init
-            yarn install --frozen-lockfile
+      - template: templates/apple-install-dependencies.yml
+
+      - template: templates/apple-release-setup.yml
 
       - task: CmdLine@2
-        displayName: yarn build
+        displayName: Build react-native-macos-init
         inputs:
           script: |
             cd packages/react-native-macos-init

.ado/gitTagRelease.js

@@ -0,0 +1,12 @@
+steps:
+  - task: CmdLine@2
+    displayName: yarn install
+    inputs:
+      script: yarn install --frozen-lockfile
+
+  - task: CmdLine@2
+    displayName: bundle install
+    inputs:
+      script: |
+        cd packages/rn-tester
+        bundle install

.ado/publish.yml

@@ -1,9 +1,13 @@
-
 steps:
-
   - task: CmdLine@2
     displayName: Configure git
     inputs:
       script: |
         git config --global user.email "[email protected]"
         git config --global user.name "React-Native Bot"
+
+  - task: CmdLine@2
+    displayName: Set NPM Auth Token
+    inputs:
+      script: |
+        echo "//registry.npmjs.org/:_authToken=${npmAuthToken}" > ~/.npmrc

.ado/removeWorkspaceConfig.js

@@ -1,7 +1,7 @@
 steps:
   - task: NodeTool@0
     inputs:
-      versionSource: 'fromFile' # 'spec' | 'fromFile'. Required. Source of version. Default: spec.
+      versionSource: 'fromFile'
       versionFilePath: '.node-version'
 
   - task: UseRubyVersion@0

.ado/restoreWorkspaceConfig.js

@@ -2,3 +2,4 @@ variables:
   VmImageApple: internal-macos12
   slice_name: 'Xcode_14.2'
   xcode_version: '/Applications/Xcode_14.2.app'
+  latest_stable_branch: '0.71-stable'

.ado/templates/apple-install-dependencies.yml

@@ -44,7 +44,11 @@ const argv = yargs
     default: false,
   }).argv;
 
-const branch = process.env.CIRCLE_BRANCH;
+// [macOS Use git to get the branch name, rather than relying on CircleCI env vars.
+const branch = exec('git rev-parse --abbrev-ref HEAD', {
+  silent: true,
+}).stdout.trim();
+// // macOS]
 const remote = argv.remote;
 const releaseVersion = argv.toVersion;
 const isLatest = argv.latest;
@@ -102,7 +106,8 @@ if (exec(`git commit -a -m "[${version}] Bump version numbers"`).code) {
 }
 
 // Add tag v0.21.0-rc.1
-if (exec(`git tag -a v${version} -m "v${version}"`).code) {
+// [macOS] Add "-microsoft" suffix to tag to distinguish from React Native Core.
+if (exec(`git tag -a v${version}-microsoft -m "v${version}-microsoft"`).code) {
   echo(
     `failed to tag the commit with v${version}, are you sure this release wasn't made earlier?`,
   );