Skip to content

Commit dcacb44

Browse files
authored
Do not define ENUM_BITFIELDS_NOT_SUPPORTED for MSVC (#230)
In order to move to OSS React Native, Windows needs to define ENUM_BITFIELDS_NOT_SUPPORTED. This causes warnings treated as errors on the microsoft fork due to macro redefinition. Remove the code that automatically adds this definiion. This allows the removal of the YGStyle patch added to RNW. At item was created to remove this entire chunk once we're off the fork.
1 parent be9374b commit dcacb44

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

ReactCommon/yoga/yoga/YGStyle.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,6 @@
1717
#include "Yoga.h"
1818

1919

20-
// Until we sync past this: https://github.com/facebook/react-native/commit/a7e4ce0f0d83b6162d77db7d680e838666f6d938#diff-140c478f1096be49a1b121931a7680ee
21-
// We have to turn off the bitfield usage for MSVC builds
22-
#ifdef _MSC_VER
23-
#define ENUM_BITFIELDS_NOT_SUPPORTED
24-
#endif
25-
2620
#if !defined(ENUM_BITFIELDS_NOT_SUPPORTED)
2721
#define BITFIELD_ENUM_SIZED(num) : num
2822
#else

0 commit comments

Comments
 (0)