Skip to content

Commit e2dbf40

Browse files
authored
Fixing release-only crash for when specifying validKeys[Down|Up] (#1883)
Wrong macro -- use `RCT_ARRAY_CONVERTER`, not `RCT_JSON_ARRAY_CONVERTER`. The latter is for "directly representable json array values that require no conversion.": `/** * This macro is used for creating converter functions for directly * representable json array values that require no conversion. */ +(NSArray *)name##Array : (id)json \ { \ return json; \ } `/** * This macro is used for creating converter functions for typed arrays. * RCT_ARRAY_CONVERTER_NAMED may be used when type contains characters * which are disallowed in selector names. */
1 parent 7b5c55d commit e2dbf40

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

React/Base/RCTConvert.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1502,7 +1502,7 @@ + (NSString *)accessibilityRoleFromTraits:(id)json
15021502
return NSAccessibilityUnknownRole;
15031503
}
15041504

1505-
RCT_JSON_ARRAY_CONVERTER(RCTHandledKey);
1505+
RCT_ARRAY_CONVERTER(RCTHandledKey);
15061506

15071507
#endif // macOS]
15081508

0 commit comments

Comments
 (0)