Skip to content

Commit 95b0d72

Browse files
authored
fix: browser debugging in remotes not working (#1629)
Fixes #1628 Moving to esbuild caused it to pull in the "wrapper.mjs" which doesn't expose the same API that `ws` normally does. See websockets/ws#2032 (comment)
1 parent 1908507 commit 95b0d72

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ This changelog records changes to stable releases since 1.50.2. "TBA" changes he
66

77
- fix: debugger failing on Node <=12 ([#1624](https://github.com/microsoft/vscode-js-debug/issues/1624))
88
- fix: sourcemap lookups on ipv6 localhost addresses ([vscode#167353](https://github.com/microsoft/vscode/issues/167353))
9+
- fix: browser debugging in remotes not working ([#1628](https://github.com/microsoft/vscode-js-debug/issues/1628))
910
- feat: support ETX in stdio console endings ([vscode#175763](https://github.com/microsoft/vscode/issues/175763))
1011

1112
## v1.77 (March 2023)

src/common/findOpenPort.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,10 @@ export const makeAcquireTcpServer =
111111
export const makeAcquireWebSocketServer =
112112
(options?: WebSocket.ServerOptions): PortTesterFn<WebSocket.Server> =>
113113
(port, ct) =>
114-
waitForServerToListen(new WebSocket.Server({ host: '127.0.0.1', ...options, port }), ct);
114+
waitForServerToListen(
115+
new WebSocket.WebSocketServer({ host: '127.0.0.1', ...options, port }),
116+
ct,
117+
);
115118

116119
interface IServerLike {
117120
on(event: 'error', handler: (err: Error) => void): void;

src/test/browser/browser-launch.test.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,10 @@ describe('browser launch', () => {
4747

4848
itIntegrates('connects to rewritten websocket when using inspectUri parameter', async ({ r }) => {
4949
const pagePort = 5935;
50-
const wsServer = new WebSocket.Server({ port: pagePort, path: '/_framework/debug/ws-proxy' });
50+
const wsServer = new WebSocket.WebSocketServer({
51+
port: pagePort,
52+
path: '/_framework/debug/ws-proxy',
53+
});
5154

5255
try {
5356
const receivedMessage = new Promise(resolve => {

0 commit comments

Comments
 (0)