useHostProxy > isUseHostProxyEnabled() (microsoft/vscode-copilot-release#3821)

Author: chrmarti

CHANGELOG.md

@@ -1,6 +1,9 @@
 # Change Log
 Notable changes will be documented here.
 
+## [0.30.0]
+- useHostProxy > isUseHostProxyEnabled() ([microsoft/vscode-copilot-release#3821](https://github.com/microsoft/vscode-copilot-release/issues/3821))
+
 ## [0.29.0]
 - Update to undici 7.2.0 ([microsoft/vscode-proxy-agent#57](https://github.com/microsoft/vscode-proxy-agent/pull/57))
 - Get options from unpatched agents ([microsoft/vscode-proxy-agent#58](https://github.com/microsoft/vscode-proxy-agent/pull/58))

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vscode/proxy-agent",
-  "version": "0.29.0",
+  "version": "0.30.0",
   "description": "NodeJS http(s) agent implementation for VS Code",
   "main": "out/index.js",
   "types": "out/index.d.ts",

src/index.ts

@@ -74,7 +74,7 @@ export interface ProxyAgentParams {
 	log: Log;
 	getLogLevel(): LogLevel;
 	proxyResolveTelemetry(event: ProxyResolveEvent): void;
-	useHostProxy: boolean;
+	isUseHostProxyEnabled: () => boolean;
 	env: NodeJS.ProcessEnv;
 }
 
@@ -195,6 +195,12 @@ export function createProxyResolver(params: ProxyAgentParams) {
 			return;
 		}
 
+		if (!params.isUseHostProxyEnabled()) {
+			callback('DIRECT');
+			log.debug('ProxyResolver#resolveProxy unconfigured', url, 'DIRECT', stackText);
+			return;
+		}
+
 		const key = getCacheKey(parsedUrl);
 		const proxy = getCachedProxy(key);
 		if (proxy) {
@@ -207,12 +213,6 @@ export function createProxyResolver(params: ProxyAgentParams) {
 			return;
 		}
 
-		if (!params.useHostProxy) {
-			callback('DIRECT');
-			log.debug('ProxyResolver#resolveProxy unconfigured', url, 'DIRECT', stackText);
-			return;
-		}
-
 		const start = Date.now();
 		params.resolveProxy(url) // Use full URL to ensure it is an actually used one.
 			.then(proxy => {

tests/test-client/src/utils.ts

@@ -24,7 +24,7 @@ export const directProxyAgentParams: vpa.ProxyAgentParams = {
 	log: console,
 	getLogLevel: () => vpa.LogLevel.Trace,
 	proxyResolveTelemetry: () => undefined,
-	useHostProxy: true,
+	isUseHostProxyEnabled: () => true,
 	loadAdditionalCertificates: async () => [
 		...await loadSystemCertificates({ log: console }),
 		...ca,