Skip to content

Commit 86b60ec

Browse files
committed
tree dnd todos, #32592
1 parent c1e2c6c commit 86b60ec

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

src/vscode-dts/vscode.proposed.treeViewDragAndDrop.d.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ declare module 'vscode' {
7979
/**
8080
* Provides support for drag and drop in `TreeView`.
8181
*/
82+
// TODO@api why disposable?
8283
export interface DragAndDropController<T> extends Disposable {
8384

8485
/**
@@ -96,6 +97,7 @@ declare module 'vscode' {
9697
*
9798
* @param source The source items for the drag and drop operation.
9899
*/
100+
// TODO@api I think this can be more generic, tho still constraint, e.g have something that works everywhere within VS Code
99101
onWillDrop?(source: T[]): Thenable<TreeDataTransfer>;
100102

101103
/**
@@ -106,6 +108,7 @@ declare module 'vscode' {
106108
* @param source The data transfer items of the source of the drag.
107109
* @param target The target tree element that the drop is occuring on.
108110
*/
111+
// TODO@api NIT - allow to return `Thenable<void> | void`
109112
onDrop(source: TreeDataTransfer, target: T): Thenable<void>;
110113
}
111114
}

0 commit comments

Comments
 (0)