Merge "Show Extension/Feature using this account" and "Manage Trusted Extensions"

[jrieken]

#96226

• select an account
• select "show extensions/features using this account"
• 😕 you get a quick pick that doesn't allow you to do anything at all
• select "manage trusted extension"
• 😕 you get a slight different quick pick that at least allows to check/uncheck extensions

useless picker

better picker, but it shows different info?

[rebornix]

It confuses me as well when I see different results in these two quick picks. Also it's weird that I can't turn off sync directly from the account management quick pick.

[RMacfarlane]

Couple of thoughts here:

If combining them into one, "Preferences Sync" becomes something that could potentially be unchecked, do we want to treat it any differently? The result would be that if preferences sync tries to read a token from that account, you see a consent dialog. Seems a bit weird for there not to be trust for VSCode itself, but this would then be consistent with extensions.

Erich had an idea of showing the "last used" time, when the extension or core feature last read the access token. If we added that, that would make it more obvious that some extensions have actually used a token during this session, and some have not.

[sandy081]

What happens if I uncheck in general say on Github Pull Requests Nightly Build ?

[RMacfarlane]

If you uncheck an extension and it tries to read an access token, a consent prompt is shown. Otherwise it is able to read the access token silently. It's similar to how "Trusted Domains" behaves

[RMacfarlane]

I removed the "Show features and extensions using this account" option and have added timestamps showing when an extension last accessed the account in "Manage Trusted Extensions".

Preferences sync is not listed there, it's only extensions. We can show which account is being used by preferences sync by exploring a richer accounts UI: #97168