Skip to content

Commit 86d87cc

Browse files
github-actions[bot]actions-usermkashwin
authored
Updating protocol buffers version to v28.0 (#1134)
* 64edebc - Github Actions - 2024-09-01 02:10:26 Upgrade to protocol buffer release v28.0 --------- Co-authored-by: Github Actions <[email protected]> Co-authored-by: Ashwin Krishnan <[email protected]>
1 parent 697e53f commit 86d87cc

File tree

23 files changed

+926
-911
lines changed

23 files changed

+926
-911
lines changed

02_mqtt-cluster/README.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ Where in:
3434

3535
1. **Step 1**: Download or install protoc. Refer
3636
* [Installing on Linux/MacOs](https://grpc.io/docs/protoc-installation/)
37-
* [Install pre-compiled version](https://github.com/protocolbuffers/protobuf/releases). This project currently is using version [Protocol Buffers v27.3](https://github.com/protocolbuffers/protobuf/releases/tag/v27.3)
37+
* [Install pre-compiled version](https://github.com/protocolbuffers/protobuf/releases). This project currently is using version [Protocol Buffers v28.0](https://github.com/protocolbuffers/protobuf/releases/tag/v28.0)
3838
and downloaded the pre-compiled versions for linux-x86_64 and win64. For other platforms please replace with the appropriate runtime or compile the runtime directly
3939
1. **Step 2**: Copy the [SparkPlugB protocol buffer specification](https://github.com/eclipse/tahu/tree/master/sparkplug_b/sparkplug_b.proto) from [Eclipse Tahu project](https://github.com/eclipse/tahu/tree/master/sparkplug_b) to the folder [./sparkplug_b](./sparkplug_b/)
4040
1. **Step 3**: Compile the SparkplugB protocol buffer into python class by the following command
@@ -235,11 +235,11 @@ poetry run pytest test/
235235

236236
1. The protoc executable for [Linux](./protobuf/bin/protoc) is for x86_64 architecture and will need execute rights to be able to run and compile the [sparkplug_b.proto](./sparkplug_b/sparkplug_b.proto) specification.
237237
The protoc executable for [Windows](./protobuf/bin/protoc.exe) is for a 64 bit processor.
238-
For other architectures please download the appropriate pre compiled version of [Protobuf release v27.3](https://github.com/protocolbuffers/protobuf/releases/tag/v27.3) e.g.
239-
* [protoc-27.3-linux-aarch_64.zip](https://github.com/protocolbuffers/protobuf/releases/download/v27.3/protoc-27.3-linux-aarch_64.zip)
240-
* [protoc-27.3-linux-ppcle_64.zip](https://github.com/protocolbuffers/protobuf/releases/download/v27.3/protoc-27.3-linux-ppcle_64.zip)
241-
* [protoc-27.3-linux-x86_32.zip](https://github.com/protocolbuffers/protobuf/releases/download/v27.3/protoc-27.3-linux-x86_32.zip)
242-
* [protoc-27.3-win32.zip](https://github.com/protocolbuffers/protobuf/releases/download/v27.3/protoc-27.3-win32.zip)
238+
For other architectures please download the appropriate pre compiled version of [Protobuf release v28.0](https://github.com/protocolbuffers/protobuf/releases/tag/v28.0) e.g.
239+
* [protoc-28.0-linux-aarch_64.zip](https://github.com/protocolbuffers/protobuf/releases/download/v28.0/protoc-28.0-linux-aarch_64.zip)
240+
* [protoc-28.0-linux-ppcle_64.zip](https://github.com/protocolbuffers/protobuf/releases/download/v28.0/protoc-28.0-linux-ppcle_64.zip)
241+
* [protoc-28.0-linux-x86_32.zip](https://github.com/protocolbuffers/protobuf/releases/download/v28.0/protoc-28.0-linux-x86_32.zip)
242+
* [protoc-28.0-win32.zip](https://github.com/protocolbuffers/protobuf/releases/download/v28.0/protoc-28.0-win32.zip)
243243

244244
1. Need to understand how to handle metric types DataSet, Template
245245

02_mqtt-cluster/poetry.lock

Lines changed: 46 additions & 42 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

02_mqtt-cluster/protobuf/bin/protoc

1.93 KB
Binary file not shown.
-338 KB
Binary file not shown.
-485 KB
Binary file not shown.

02_mqtt-cluster/protobuf/include/google/protobuf/cpp_features.proto

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ message CppFeatures {
2424
retention = RETENTION_RUNTIME,
2525
targets = TARGET_TYPE_FIELD,
2626
targets = TARGET_TYPE_FILE,
27-
// TODO Enable this in google3 once protoc rolls out.
2827
feature_support = {
2928
edition_introduced: EDITION_2023,
3029
edition_deprecated: EDITION_2023,
@@ -33,7 +32,7 @@ message CppFeatures {
3332
"edition 2025. Mark enum type on the enum "
3433
"definitions themselves rather than on fields.",
3534
},
36-
edition_defaults = { edition: EDITION_PROTO2, value: "true" },
35+
edition_defaults = { edition: EDITION_LEGACY, value: "true" },
3736
edition_defaults = { edition: EDITION_PROTO3, value: "false" }
3837
];
3938

@@ -48,11 +47,10 @@ message CppFeatures {
4847
retention = RETENTION_RUNTIME,
4948
targets = TARGET_TYPE_FIELD,
5049
targets = TARGET_TYPE_FILE,
51-
// TODO Enable this in google3 once protoc rolls out.
5250
feature_support = {
5351
edition_introduced: EDITION_2023,
5452
},
55-
edition_defaults = { edition: EDITION_PROTO2, value: "STRING" },
53+
edition_defaults = { edition: EDITION_LEGACY, value: "STRING" },
5654
edition_defaults = { edition: EDITION_2024, value: "VIEW" }
5755
];
5856
}

0 commit comments

Comments
 (0)