Allow to turn off monitoring of output control ports

Signed-off-by: falkTX <[email protected]>

Author: falkTX

README.md

@@ -91,7 +91,7 @@ Options
     -i, --interactive
         interactive shell mode
 
-    -n, --nofork 
+    -n, --nofork
         run in non-forking mode
 
     -V, --version
@@ -196,6 +196,10 @@ The commands supported by mod-host are:
         * request monitoring of an output control port (on the feedback port)
         e.g.: monitor_output 0 "meter"
 
+    monitor_output_off <instance_number> <param_symbol>
+        * turn off monitoring of an output control port (on the feedback port)
+        e.g.: monitor_output_off 0 "meter"
+
     midi_learn <instance_number> <param_symbol> <minimum> <maximum>
         * start MIDI learn for a control port
         e.g.: midi_learn 0 "gain" 0.0 1.0

src/effects.c

@@ -6838,7 +6838,7 @@ int effects_monitor_parameter(int effect_id, const char *control_symbol, const c
     return SUCCESS;
 }
 
-int effects_monitor_output_parameter(int effect_id, const char *control_symbol_or_uri)
+int effects_monitor_output_parameter(int effect_id, const char *control_symbol_or_uri, int enable)
 {
     port_t *port;
 
@@ -6850,6 +6850,42 @@ int effects_monitor_output_parameter(int effect_id, const char *control_symbol_o
 
     if (port != NULL)
     {
+        if (enable == 0)
+        {
+            // check if not monitored
+            if ((port->hints & HINT_MONITORED) == 0)
+                return SUCCESS;
+
+            // remove monitored flag
+            port->hints &= ~HINT_MONITORED;
+
+            // stop postpone events thread
+            if (g_postevents_running == 1)
+            {
+                g_postevents_running = 0;
+                sem_post(&g_postevents_semaphore);
+                pthread_join(g_postevents_thread, NULL);
+            }
+
+            // flush events for all effects except this one
+            RunPostPonedEvents(effect_id);
+
+            // start thread again
+            if (g_postevents_running == 0)
+            {
+                if (g_verbose_debug)
+                {
+                    puts("DEBUG: effects_monitor_output_parameter restarted RunPostPonedEvents thread");
+                    fflush(stdout);
+                }
+
+                g_postevents_running = 1;
+                pthread_create(&g_postevents_thread, NULL, PostPonedEventsThread, NULL);
+            }
+
+            return SUCCESS;
+        }
+
         // check if already monitored
         if (port->hints & HINT_MONITORED)
             return SUCCESS;
@@ -6882,7 +6918,7 @@ int effects_monitor_output_parameter(int effect_id, const char *control_symbol_o
         if (property == NULL)
             return ERR_LV2_INVALID_PARAM_SYMBOL;
 
-        property->monitored = true;
+        property->monitored = enable != 0;
     }
 
     // activate output monitor

src/effects.h

@@ -155,7 +155,7 @@ int effects_flush_parameters(int effect_id, int reset, int param_count, const fl
 int effects_set_property(int effect_id, const char *uri, const char *value);
 int effects_get_property(int effect_id, const char *uri);
 int effects_monitor_parameter(int effect_id, const char *control_symbol, const char *op, float value);
-int effects_monitor_output_parameter(int effect_id, const char *control_symbol);
+int effects_monitor_output_parameter(int effect_id, const char *control_symbol, int enable);
 int effects_bypass(int effect_id, int value);
 int effects_get_parameter_symbols(int effect_id, int output_ports, const char** symbols);
 int effects_get_presets_uris(int effect_id, const char **uris);

src/mod-host.c

@@ -348,7 +348,14 @@ static void monitor_addr_set_cb(proto_t *proto)
 static void monitor_output_cb(proto_t *proto)
 {
     int resp;
-    resp = !effects_monitor_output_parameter(atoi(proto->list[1]), proto->list[2]);
+    resp = !effects_monitor_output_parameter(atoi(proto->list[1]), proto->list[2], 1);
+    protocol_response_int(resp, proto);
+}
+
+static void monitor_output_off_cb(proto_t *proto)
+{
+    int resp;
+    resp = !effects_monitor_output_parameter(atoi(proto->list[1]), proto->list[2], 0);
     protocol_response_int(resp, proto);
 }
 
@@ -768,6 +775,7 @@ static int mod_host_init(jack_client_t* client, int socket_port, int feedback_po
     protocol_add_command(EFFECT_SET_BPB, effects_set_beats_per_bar_cb);
     protocol_add_command(MONITOR_ADDR_SET, monitor_addr_set_cb);
     protocol_add_command(MONITOR_OUTPUT, monitor_output_cb);
+    protocol_add_command(MONITOR_OUTPUT_OFF, monitor_output_off_cb);
     protocol_add_command(MONITOR_AUDIO_LEVELS, monitor_audio_levels_cb);
     protocol_add_command(MONITOR_MIDI_PROGRAM, monitor_midi_program_cb);
     protocol_add_command(MIDI_LEARN, midi_learn_cb);

src/mod-host.h

@@ -73,6 +73,7 @@
 #define EFFECT_SET_BPB       "set_bpb %f"
 #define MONITOR_ADDR_SET     "monitor %s %i %i"
 #define MONITOR_OUTPUT       "monitor_output %i %s"
+#define MONITOR_OUTPUT_OFF   "monitor_output_off %i %s"
 #define MONITOR_AUDIO_LEVELS "monitor_audio_levels %i %s"
 #define MONITOR_MIDI_PROGRAM "monitor_midi_program %i %i"
 #define MIDI_LEARN           "midi_learn %i %s %f %f"