Skip to content

Commit 825c33e

Browse files
committed
fix: fix return types from Settings helper class
1 parent 998b2e4 commit 825c33e

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

core/components/modai/src/Settings.php

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ public function __construct(string $setting)
1111
}
1212

1313
class Settings {
14-
private static function getOption(modX $modx, string $namespace, string $field, string $area, string $setting)
14+
private static function getOption(modX $modx, string $namespace, string $field, string $area, string $setting): ?string
1515
{
1616
if (!empty($field)) {
1717
$value = $modx->getOption("$namespace.$field.$area.$setting");
@@ -47,7 +47,7 @@ private static function getOption(modX $modx, string $namespace, string $field,
4747
/**
4848
* @throws RequiredSettingException
4949
*/
50-
public static function getTextSetting(modX $modx, string $field, string $setting, string $namespace = 'modai', bool $required = true): string
50+
public static function getTextSetting(modX $modx, string $field, string $setting, string $namespace = 'modai', bool $required = true): ?string
5151
{
5252
$value = self::getOption($modx, $namespace, $field, 'text', $setting);
5353

@@ -61,7 +61,7 @@ public static function getTextSetting(modX $modx, string $field, string $setting
6161
/**
6262
* @throws RequiredSettingException
6363
*/
64-
public static function getImageSetting(modX $modx, string $field, string $setting, string $namespace = 'modai', bool $required = true): string
64+
public static function getImageSetting(modX $modx, string $field, string $setting, string $namespace = 'modai', bool $required = true): ?string
6565
{
6666
$value = self::getOption($modx, $namespace, $field, 'image', $setting);
6767

@@ -75,7 +75,7 @@ public static function getImageSetting(modX $modx, string $field, string $settin
7575
/**
7676
* @throws RequiredSettingException
7777
*/
78-
public static function getVisionSetting(modX $modx, string $field, string $setting, string $namespace = 'modai', bool $required = true): string
78+
public static function getVisionSetting(modX $modx, string $field, string $setting, string $namespace = 'modai', bool $required = true): ?string
7979
{
8080
$value = self::getOption($modx, $namespace, $field, 'vision', $setting);
8181

@@ -86,11 +86,13 @@ public static function getVisionSetting(modX $modx, string $field, string $setti
8686
return $value;
8787
}
8888

89-
public static function getSetting(modX $modx, string $key, string $default = null) {
89+
public static function getSetting(modX $modx, string $key, string $default = null): ?string
90+
{
9091
return $modx->getOption("modai.$key", null, $default);
9192
}
9293

93-
public static function getApiSetting(modX $modx, string $service, string $key) {
94+
public static function getApiSetting(modX $modx, string $service, string $key): ?string
95+
{
9496
return $modx->getOption("modai.api.$service.$key", null, $modx->getOption("modai.api.$key"));
9597
}
9698
}

0 commit comments

Comments
 (0)