Skip to content

Commit acb0cf6

Browse files
kohlschuetterslachiewicz
authored andcommitted
Update maven-filtering dependency; replace deprecated FileUtils methods
Update maven-filtering to 3.3.1. Replace maven-shared-utils' FileUtils calls by commons-io FileUtils, as shown in deprecation markings.
1 parent 7c06b36 commit acb0cf6

File tree

3 files changed

+11
-12
lines changed

3 files changed

+11
-12
lines changed

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@
106106
<properties>
107107
<mavenVersion>3.2.5</mavenVersion>
108108
<mojo.java.target>8</mojo.java.target>
109-
<mavenFilteringVersion>3.1.1</mavenFilteringVersion>
109+
<mavenFilteringVersion>3.3.1</mavenFilteringVersion>
110110
<scmpublish.content>target/staging/${project.artifactId}</scmpublish.content>
111111
</properties>
112112

src/test/java/org/codehaus/mojo/templating/AbstractFilterSourcesMojoTest.java

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -20,17 +20,21 @@
2020
*/
2121

2222
import static org.assertj.core.api.Assertions.assertThat;
23+
import static org.mockito.ArgumentMatchers.any;
24+
import static org.mockito.Mockito.doAnswer;
25+
import static org.mockito.Mockito.times;
26+
import static org.mockito.Mockito.verify;
2327

2428
import java.io.File;
2529
import java.io.IOException;
2630

31+
import org.apache.commons.io.FileUtils;
2732
import org.apache.maven.execution.MavenSession;
2833
import org.apache.maven.plugin.MojoExecutionException;
2934
import org.apache.maven.project.MavenProject;
3035
import org.apache.maven.shared.filtering.MavenFilteringException;
3136
import org.apache.maven.shared.filtering.MavenResourcesExecution;
3237
import org.apache.maven.shared.filtering.MavenResourcesFiltering;
33-
import org.apache.maven.shared.utils.io.FileUtils;
3438
import org.junit.Before;
3539
import org.junit.Test;
3640
import org.junit.runner.RunWith;
@@ -41,11 +45,6 @@
4145
import org.mockito.junit.MockitoJUnitRunner;
4246
import org.mockito.stubbing.Answer;
4347

44-
import static org.mockito.ArgumentMatchers.any;
45-
import static org.mockito.Mockito.doAnswer;
46-
import static org.mockito.Mockito.times;
47-
import static org.mockito.Mockito.verify;
48-
4948
/**
5049
* @author Krzysztof Suszyński <[email protected]>
5150
* @since 2015-11-17
@@ -76,7 +75,7 @@ public void before()
7675
throws IOException
7776
{
7877
File target = resolve( project.getBasedir(), outputDirectory.getPath() );
79-
FileUtils.forceDelete( target );
78+
FileUtils.deleteQuietly( target );
8079
}
8180

8281
@Test
@@ -135,7 +134,7 @@ public Void answer( InvocationOnMock invocation )
135134
assertThat( source ).isDirectory();
136135
File destination = arg.getOutputDirectory();
137136
assertThat( destination ).doesNotExist();
138-
FileUtils.copyDirectoryStructure( source, destination );
137+
FileUtils.copyDirectory( source, destination );
139138
return null;
140139
}
141140
}

src/test/java/org/codehaus/mojo/templating/MavenProjectStub.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,11 @@
2626
import java.util.ArrayList;
2727
import java.util.List;
2828

29+
import org.apache.commons.io.input.XmlStreamReader;
2930
import org.apache.maven.model.Build;
3031
import org.apache.maven.model.Model;
3132
import org.apache.maven.model.io.xpp3.MavenXpp3Reader;
3233
import org.apache.maven.project.MavenProject;
33-
import org.apache.maven.shared.utils.ReaderFactory;
3434

3535
/**
3636
* @author Krzysztof Suszyński <[email protected]>
@@ -60,9 +60,9 @@ private void initiate()
6060
{
6161
MavenXpp3Reader pomReader = new MavenXpp3Reader();
6262
Model model;
63-
try
63+
try ( XmlStreamReader in = new XmlStreamReader( new File( getBasedir(), "pom.xml" ) ) )
6464
{
65-
model = pomReader.read( ReaderFactory.newXmlReader( new File( getBasedir(), "pom.xml" ) ) );
65+
model = pomReader.read(in);
6666
setModel( model );
6767
}
6868
catch ( Exception e )

0 commit comments

Comments
 (0)